fix(libnmxm): stop deriving Debug for endpoint types

poroh · poroh · commit 9619defed4a0 · 2026-04-10T15:25:54.000-07:00
Remove `Debug` derives from `Endpoint`, `NmxmApiClient`, and `NmxmApi`
to avoid accidentally logging credentials contained in endpoint data.

Also bump `libredfish` from `v0.43.7` to `v0.43.8`

Signed-off-by: Dmitry Porokh &lt;dporokh@nvidia.com&gt;
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -26,7 +26,7 @@ authors = ["NVIDIA Carbide Engineering <carbide-dev@exchange.nvidia.com>"]
 
 [workspace.dependencies]
 clap = { version = "4", features = ["derive", "env"] }
-libredfish = { git = "https://github.com/NVIDIA/libredfish.git", tag = "v0.43.7" }
+libredfish = { git = "https://github.com/NVIDIA/libredfish.git", tag = "v0.43.8" }
 librms = { git = "https://github.com/NVIDIA/nv-rms-client.git", tag = "v0.0.5" }
 ansi-to-html = "0.2.2"
 
diff --git a/crates/libnmxm/src/lib.rs b/crates/libnmxm/src/lib.rs
@@ -87,7 +87,7 @@ pub enum NmxmApiError {
     InvalidArguments,
 }
 
-#[derive(Debug, Clone, PartialEq, Eq)]
+#[derive(Clone, PartialEq, Eq)] // WARN: Do not derive Debug: Endpoint may contain credentials and must not be logged accidentally.
 pub struct Endpoint {
     pub host: String,
     pub username: Option<String>,
@@ -147,7 +147,7 @@ impl NmxmClientPool {
     }
 }
 
-#[derive(Debug, Clone)]
+#[derive(Clone)]
 pub struct NmxmApiClient {
     endpoint: Endpoint,
     client: HttpClient,
diff --git a/crates/libnmxm/src/nmxm_api.rs b/crates/libnmxm/src/nmxm_api.rs
@@ -65,7 +65,7 @@ macro_rules! async_operation {
     }};
 }
 
-#[derive(Clone, Debug)]
+#[derive(Clone)]
 pub struct NmxmApi {
     pub client: NmxmApiClient,
 }

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ pub enum NmxmApiError {`
`87`	`87`	`InvalidArguments,`
`88`	`88`	`}`
`89`	`89`
`90`		`-#[derive(Debug, Clone, PartialEq, Eq)]`
	`90`	`+#[derive(Clone, PartialEq, Eq)] // WARN: Do not derive Debug: Endpoint may contain credentials and must not be logged accidentally.`
`91`	`91`	`pub struct Endpoint {`
`92`	`92`	`pub host: String,`
`93`	`93`	`pub username: Option<String>,`
`@@ -147,7 +147,7 @@ impl NmxmClientPool {`
`147`	`147`	`}`
`148`	`148`	`}`
`149`	`149`
`150`		`-#[derive(Debug, Clone)]`
	`150`	`+#[derive(Clone)]`
`151`	`151`	`pub struct NmxmApiClient {`
`152`	`152`	`endpoint: Endpoint,`
`153`	`153`	`client: HttpClient,`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ macro_rules! async_operation {`
`65`	`65`	`}};`
`66`	`66`	`}`
`67`	`67`
`68`		`-#[derive(Clone, Debug)]`
	`68`	`+#[derive(Clone)]`
`69`	`69`	`pub struct NmxmApi {`
`70`	`70`	`pub client: NmxmApiClient,`
`71`	`71`	`}`