Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta package for numba_extensions #7

Open
isVoid opened this issue Mar 22, 2024 · 4 comments
Open

Meta package for numba_extensions #7

isVoid opened this issue Mar 22, 2024 · 4 comments
Labels
enhancement New feature or request P1 Next in priority queue

Comments

@isVoid
Copy link
Collaborator

isVoid commented Mar 22, 2024

Currently all modules under numba_extensions are organized independently as packages. @gmarkall at one point mentions that we could organized them into cuda package. In #6, I didn't do that largely because of two considerations:

  1. Pluggable installation: developers can choose which cuda library they like to use and only install those that are needed.
  2. Name conflicts: other python package might also be named cuda.

However, I'm still very interested in organizing all extensions under a meta package. I'd like to hear pro and cons on both sides.

@isVoid isVoid added P1 Next in priority queue enhancement New feature or request labels Mar 25, 2024
@quasiben
Copy link
Collaborator

Assuming overall package size is not substantial (>20-30MB), I would be in favor of reducing complexity and shipping all extensions in a single package. This should reduce the burden on packaging and potential confusion for the user

@isVoid
Copy link
Collaborator Author

isVoid commented Mar 27, 2024

Any idea on what this package should be named?

Alternatively can we install this as a "submodule" for cuda? (I recall things like cuda.nvrtc can be installed optionally from rest of cuda python). So there should be a way to make all the above as an optional submodule for cuda. E.g. cuda.bf16, cuda.fp16, etc.

@quasiben
Copy link
Collaborator

quasiben commented May 1, 2024

I think it's technically possible to install as a submodule for cuda but I would be hesitant to do this without negotiating with cuda-python folks. Or did you mean as a submodule for numba.cuda ?

@isVoid
Copy link
Collaborator Author

isVoid commented May 6, 2024

From what I see over the past few weeks, I think each team has their own use case. Some may want the bindings to live with their own package (curand) and others may want this to live with numba. Shall we stay flexible for the moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 Next in priority queue
Projects
None yet
Development

No branches or pull requests

2 participants