release: Enable Immutable Releases#127
Merged
zvonkok merged 1 commit intoNVIDIA:mainfrom Jan 14, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements immutable releases by ensuring that releases are created as drafts first, then published only after all assets (binaries, signatures, provenance, and release notes) have been uploaded successfully. This prevents partial releases from being visible to end users.
Changes:
- All release operations now interact with draft releases until final publication
- New
publish-releasejob publishes the draft release as the final step - Signature verification now runs after publication to ensure release integrity
Comments suppressed due to low confidence (1)
.github/workflows/release.yaml:49
- The preflight check at line 46 will fail if a draft release already exists from a previous failed workflow run. The check should either exclude draft releases or delete existing draft releases before proceeding. Consider adding
--exclude-draftsflag or checking the release state and deleting drafts for the tag before failing.
- name: Fail if Release already exists for this tag
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
shell: bash
run: |
set -euo pipefail
TAG="${{ steps.reltag.outputs.tag }}"
if gh release view "$TAG" --repo "${{ github.repository }}" >/dev/null 2>&1; then
echo "Release $TAG already exists. Aborting to avoid overwrite." >&2
exit 1
fi
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release: Enable Immutable Releases