Skip to content

Row Major Eigen Backend #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwaldrop107 merged 1 commit into from
Nov 15, 2024
Merged

Row Major Eigen Backend #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/tensorwrapper/backends/eigen.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ namespace tensorwrapper::eigen {
#ifdef TENSORWRAPPER_HAS_EIGEN

template<typename FloatType, unsigned short Rank>
using data_type = Eigen::Tensor<FloatType, int(Rank)>;
using data_type = Eigen::Tensor<FloatType, int(Rank), Eigen::RowMajor>;

#else

Expand Down
5 changes: 3 additions & 2 deletions tests/cxx/unit_tests/tensorwrapper/buffer/eigen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ namespace {

template<typename FloatType, typename LHSType, typename RHSType>
bool compare_eigen(const LHSType& lhs, const RHSType& rhs) {
auto d = lhs - rhs;
Eigen::Tensor<FloatType, 0> r = d.sum();
using r_type = Eigen::Tensor<FloatType, 0, Eigen::RowMajor>;
auto d = lhs - rhs;
r_type r = d.sum();

return (r() == 0.0);
}
Expand Down