Make ServerRunnable fields volatile for thread safety #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NanoHTTPD.java's
start(final int timeout, boolean daemon)method uses inter-thread communication to signal the status of the daemon thread. Section 17.3 of the Java Lang Specification states that Thread.sleep has no synchronization semantics, so the compiler does not have to reload values cached in registers after a call to Thread.sleep. This means that the while loop in start() might never terminate, even if the other thread changed the status.Changing the variables to volatile would require Java to reload the values after each cycle.