get_transactions bug, fail with Natural subtraction underflow

[ic-dstar]

If It has 3 transactions, call get_transactions fail with Natural subtraction underflow.
you can test it if set a length less than start (by search inside transactions).

// dfx call
call get_transactions '(record{start=2 : nat; length=1 : nat})'

the bug cause by this line.

icrc1/src/ICRC1/lib.mo

Line 352 in 2ede9a6

txs_in_canister:= SB.slice(transactions, tx_start_index, req.length);

function SB.sclice accept argument (buffer, start, end)

icrc1/src/ICRC1/Utils.mo

Line 261 in 2ede9a6

StableBuffer with slice = func<A>(buffer : T.StableBuffer<A>, start : Nat, end : Nat) : [A] {

but the code call it , SB.slice(transactions, tx_start_index, req.length).

it should fix to

SB.slice(transactions, tx_start_index,  tx_start_index + req.length).

could you fix this? or may I pull a request.

[tomijaga]

Hey @ic-dstar,
Thanks for reporting the issue.

Feel free to submit a pull request so it can be quickly resolved.
I'll add more extensive tests for the get_transactions() fn later to prevent future errors.

[tomijaga]

Hey @ic-dstar,
Your PR has been merged into the main branch.
Let me know if any other issue comes up.