New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small error in Transfer.mo:217 #8

Open

sardariuss opened this issue Apr 5, 2023 · 0 comments

sardariuss commented Apr 5, 2023 •

edited

Loading

Currently it is:if (tx_req.amount > balance + token._fee) {

It shall be: if (tx_req.amount + token._fee > balance) {

Luckily right now it traps with a "Natural subtraction underflow" preventing the transfer. But it should return the error #InsufficientFunds instead.

Way to reproduce: transfer the exact balance from the account (without subtracting the fee from it).

Ultimatly it would be nice to have a test for it :)

tomijaga mentioned this issue

Update Conditional error in Transfer module #9

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment