Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AccumuloSyntaxParserConstants so it is not an interface #2740

Open
wants to merge 1 commit into
base: integration
Choose a base branch
from
Open

Refactor AccumuloSyntaxParserConstants so it is not an interface #2740

wants to merge 1 commit into from

Conversation

lbschanno
Copy link
Collaborator

Refactor AccumuloSyntaxParserConstants so that it is not an interface that consists solely of constants, but is rather a final, uninstantiable class with constants. While not strictly an issue, it is odd for AccumuloSyntaxParser and AccumuloSyntaxParserTokenManager to both be considered implementations of AccumuloSyntaxParserConstants.

Closes #2739

@lbschanno
Refactor AccumuloSyntaxParserConstants so it is not an interface
35ee1f8 
Refactor AccumuloSyntaxParserConstants so that it is not an interface
that consists solely of constants, but is rather a final, uninstantiable
class with constants. While not strictly an issue, it is odd for
AccumuloSyntaxParser and AccumuloSyntaxParserTokenManager to both be
considered implementations of AccumuloSyntaxParserConstants.

Closes #2739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apmoriarty apmoriarty apmoriarty approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor AccumuloSyntaxParserConstants class so it is not an interface
2 participants
@lbschanno @apmoriarty