Creating a Namespace does not update Symbol Tree node

[gynt]

Describe the bug
The bug occurs when using the UI or createNamespace to create a Namespace that is nested multiple levels. In order to refresh the Symbol Tree node, the root node has to be collapsed and uncollapsed.

To Reproduce
Steps to reproduce the behavior:

1. In the Symbol Tree, collapse the root node named "Namespaces".
2. Run the following script:

Global = getCurrentProgram().getGlobalNamespace()
BR01 = createNamespace(Global, "Bug-Report-01")
BR02 = createNamespace(Global, "Bug-Report-02")
A = createNamespace(BR01, "A")

3. Expand node "Namespaces" and expand all the way down to Bug-Report-01 => A
4. Right-click A and "Create Namespace" (or run createNamespace(A, "Invisible")). No new node appears but a new namespace is actually created.
5. Collapse the root "Namespaces" node.
6. Expand it again all the way down to A. Now observe the newly created Namespace with a default name of "NewNamespace"

Note that it only happens this deep into the Tree, it does not happen for me one higher, e.g. on the Bug-Report-01 level.
Note that it only happens if two Namespace nodes are collapsed into a "Summary" node, in this case "Bug-Report-0".
Note that it is also not updating if you move functions or other namespaces and classes into the bugged namespace.

Expected behavior
I expect the Namespace node to update in the UI.

Environment (please complete the following information):

• OS: Windows
• Java Version: 21.0
• Ghidra Version: 11.3.1
• Ghidra Origin: official GitHub distro

[mumbel]

#7260

[gynt]

Oops, I did read that issue and then thought my issue is different... But I guess it is not, it may be very well the exact same issue. For me it inclines to happen more often if namespaces have a "summary" node.

[mumbel]

Yeah, couldn't tell if it was 100% the same, just a reference for devs

[astrelsky]

Something similar can occur when converting a namespace to a class too.

[dragonmacher]

Based on the feedback, I think there is some latent bug in the Symbol Tree updating. That being said, I cannot reproduce OP's original issue.

I'm guessing there is some sort of timing / threading issue at play. The Symbol Tree will buffer events from the system for symbol changes. At some point the events are flushed to the tree. The tree will then run all requests in a background thread. That being said, without some way to force the issue to appear, at least periodically (like a high volume script or test), then I may not be able to find the issue.

[gynt]

@dragonmacher My project file is very large with the amount of symbols in the 10000 range. Maybe this affects the behavior. Did you test the script on a smaller project? I have an eight core 8 GB intel i5

[dragonmacher]

My project was trivial. Thanks for the extra info. I'll dig some more.

[astrelsky]

My project was trivial. Thanks for the extra info. I'll dig some more.

I see these sort of problems all the time so I find it hard to believe you are unable to reproduce.

[dragonmacher]

This area has changed a bit in master. There is a chance that your specific example above has been fixed. If you can try running from master, then you could see if it is fixed for you. Otherwise, the next release will have the change.