fix: Do not prematurely release blocks (#81) (#83)

darind · web-flow · commit d3eecf29633a · 2020-11-18T03:32:46.000-06:00
diff --git a/NativeScript/runtime/Interop.mm b/NativeScript/runtime/Interop.mm
@@ -347,8 +347,6 @@
             MethodCallbackWrapper* userData = new MethodCallbackWrapper(isolate, poCallback, 1, argsCount, blockTypeEncoding);
             blockPtr = Interop::CreateBlock(1, argsCount, blockTypeEncoding, ArgConverter::MethodCallback, userData);
 
-            [(id)blockPtr autorelease];
-
             BlockWrapper* wrapper = new BlockWrapper((void*)blockPtr, blockTypeEncoding);
             tns::SetValue(isolate, arg.As<v8::Function>(), wrapper);
         }

Original file line number	Diff line number	Diff line change
`@@ -347,8 +347,6 @@`
`347`	`347`	`MethodCallbackWrapper* userData = new MethodCallbackWrapper(isolate, poCallback, 1, argsCount, blockTypeEncoding);`
`348`	`348`	`blockPtr = Interop::CreateBlock(1, argsCount, blockTypeEncoding, ArgConverter::MethodCallback, userData);`
`349`	`349`
`350`		`- [(id)blockPtr autorelease];`
`351`		`-`
`352`	`350`	`BlockWrapper* wrapper = new BlockWrapper((void*)blockPtr, blockTypeEncoding);`
`353`	`351`	`tns::SetValue(isolate, arg.As<v8::Function>(), wrapper);`
`354`	`352`	`}`