Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring MDC into our launch for other datasets #22

Open
BenjaminMorrell opened this issue Jun 3, 2022 · 6 comments
Open

Bring MDC into our launch for other datasets #22

BenjaminMorrell opened this issue Jun 3, 2022 · 6 comments
Assignees

Comments

@BenjaminMorrell
Copy link
Contributor

No description provided.

@BenjaminMorrell
Copy link
Contributor Author

Not sure how we do this with our datasets as we saved points, not packets and do MDC in the driver - need to think how to make it more generally usable - or advise others to save packets?

@wwtinwhu
Copy link

wwtinwhu commented Sep 2, 2022

Hello @BenjaminMorrell ! Thank you to your team for an excellent job! Regarding the currently public code, I don't know if I understand it right: the MDC module is currently integrated in the velodyne driver, so the point cloud in the bag has been corrected by motion distortion. If I test my own data, I need to MDC the point cloud first and then run LOCUS.
Is the original point cloud data available? I currently downloaded the F dataset, which only contains data of type sensor_msgs/PointCloud2.

@femust
Copy link
Collaborator

femust commented Sep 2, 2022

Yeap, our custom driver has/had MDC we didn't bring that yet to the code directly. I believe that recorded bag files that we have (nebula-odometry-dataset) all the point clouds are MDC-corrected, somewhere for D dataset and F dataset we had direct packets from velodyne but they were on the nextcloud which is down... Maybe @BenjaminMorrell has some datasets locally?

I need to MDC the point cloud first and then run LOCUS.
Yes, would be useful to do that for pc_trans_in_0, pc_trans_in_1 and pc_trans_in_2 (but it also depends on how fast your robot is moving frankly speaking)

@wwtinwhu
Copy link

wwtinwhu commented Sep 2, 2022

Yeap, our custom driver has/had MDC we didn't bring that yet to the code directly. I believe that recorded bag files that we have (nebula-odometry-dataset) all the point clouds are MDC-corrected, somewhere for D dataset and F dataset we had direct packets from velodyne but they were on the nextcloud which is down... Maybe @BenjaminMorrell has some datasets locally?

I need to MDC the point cloud first and then run LOCUS. Yes, would be useful to do that for pc_trans_in_0, pc_trans_in_1 and pc_trans_in_2 (but it also depends on how fast your robot is moving frankly speaking)

Thanks @femust ! By the way, what does pc_trans_in_0 and etc mean ?

@femust
Copy link
Collaborator

femust commented Sep 2, 2022

Have a look here. So those are the real "inputs" for locus.
It is basically input of raw point clouds (i.e. from VLP-16,OS or whatever 3D sensor). Then there is preprocessing, voxelization etc and then it goes to GICP etc.

The max number of sensors is 3 though if you put in this launch file a bit of effort you can extend to more sensors.
Obviously we didn't generalize for N lidar sensors :) but you may use only with 1, so just put pc_trans_in_0 as a name of your topic point cloud

@dummyjohn77
Copy link

Hi,

Sorry if this diverts from the thread, but the query I had is related to the subject of this issue.

I was wondering if it would please be possible to release the MDC enabled Velodyne driver code-base. MDC would be a great addition to enable LOCUS into UAVs. The details of MDC was missing in the paper as well, and hence was a little confused on how to implement it from scratch.

Pardon me if it is already released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants