Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move banner hiding code to a separate package? #1698

Open
lgoettgens opened this issue May 2, 2024 · 2 comments
Open

Move banner hiding code to a separate package? #1698

lgoettgens opened this issue May 2, 2024 · 2 comments
Labels
decision question Further information is requested

Comments

@lgoettgens
Copy link
Collaborator

It seems to me that this is not particularly a feature that is tied to AA, but could be interesting for other packages as well that do not want the burden of taking the whole of AA as a dependency.
In particular, this would apply to Polymake.jl that only has AA as a dependency because of the banner code. Every minor release of AA makes a PR on each of these downstream packages necessary (e.g. oscar-system/Polymake.jl#485). Thus I think, moving this to a separate package only needs some moderate amount of work right now, but reduces the overhead each AA release has and makes it easier to update and release updates to the banner hiding code.

What do you think? @benlorenz @lkastner @fingolfin

@lgoettgens lgoettgens added question Further information is requested decision labels May 2, 2024
@lkastner
Copy link
Contributor

lkastner commented May 2, 2024

Exactly this question was brought up and discussed during the banner issue. The PIs decided against it for various reasons. Even though I agree with your suggestion, I think we should not restart this discussion.

@fieker
Copy link
Contributor

fieker commented May 2, 2024

It also comes down to having a plan to reduce the number of repositories we have to maintain....just imagine all our projects (well, AA, Nemo, Hecke, Oscar, Singular.jl, ...) would be in a single repo (by magic) available as individual packages (more magic). How much easier our life would be....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decision question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants