Maximum location length

[popey]

The location field is used for the well-known address of the venue.

In PR #453, I've made the popups show the location and credit the poster.

We currently don't have a max location length imposed, and I think we should so it doesn't overflow the box. Of course, I could truncate whatever is in that field, but it would be nice not to have to. I could also change the pop-up box size or the font.

So far, our longest location is Royal Belgian Institute of Natural Sciences, at 311 characters. It looks like this in the popup.

This location is an outlier, and should probably be fixed. The next longest locations are these, which are approximately half the one above.

158 "Cathedral Church of Christ and the Blessed Mary, the Virgin of Worcester, College Yard, Diglis, Worcester, Worcestershire, England, WR1 2LA, United Kingdom" ( content/daytrip//eu/gb/worcester-cathedral.md )
161 University of Glasgow Gilmorehill Campus, Caledonian Crescent, North Kelvinside, North Woodside, Glasgow, Glasgow City, Alba / Scotland, G12 8HH, United Kingdom ( content/daytrip//eu/gb/thomson-museum-of-anatomy.md )
167 "Suomenlinnan linnoitus, Suomenlinnan huoltotunneli, Suomenlinna, Eteläinen suurpiiri, Helsinki, Helsingin seutukunta, Uusimaa, Manner-Suomi, 00140, Suomi / Finland" ( content/daytrip//eu/fi/suomenlinna.md )
168 "Rendsburger Hochbrücke mit Schwebefähre, Am Kreishafen, Kreishafen, Rendsburg-Süd, Rendsburg, Kreis Rendsburg-Eckernförde, Schleswig-Holstein, 24768, Deutschland" ( content/daytrip//eu/de/rendsburger-hochbrcke-mit-schwebefhre.md )
170 'The Birmingham Man: Thomas Attwood (1783-1856), Chamberlain Square, Chinese Quarter, Ladywood, Park Central, Birmingham, West Midlands, England, B3 3DQ, United Kingdom' ( content/daytrip//eu/gb/the-birmingham-man.md )
183 "Cross Sound Ferry, Ferry Street, Downtown New London Historic District, Downtown New London, New London, Southeastern Connecticut Planning Region, Connecticut, 06320, United States" ( content/daytrip//na/us/cross-sound-ferry.md )

The longest of the above looks fine:

It also leaves room in case we want to add further detail or icons to represent data, or link off to other sites.

The majority are under 100 characters in length (which may also be a problem if they're too short), so will not overflow the box.

So, impose a limit, a guideline, or not?

[darkling]

I think the easiest thing that we can do to reduce address length is not use an address database to find them.

Most of the really long addresses I've modified have ended up far, far shorter when copying the address actually published by the organisation it points at. The long addresses include a whole load of stuff that's technically correct but would never actually appear on a human-rendered version of the address. To pick one of the above examples:

University of Glasgow Gilmorehill Campus,
Caledonian Crescent,
North Kelvinside,
North Woodside,
Glasgow,
Glasgow City,
Alba / Scotland, G12 8HH, United Kingdom

Why is there "Glasgow City" as well as "Glasgow"? Why both "North Kelvinside" and "North Woodside"? Indeed, why are either of those in there at all? There's only one Caledonian Crescent in Glasgow.

(As an aside, that address is wrong anyway. Caledonian Crescent is tiny, and doesn't have a museum on it. It has a good pub, but not a museum).

From what I can tell, a lot of the pre-2016 non-UK addresses suffer from the same problem. I think the original site probably took the location that someone (badly, randomly) dropped the pin, and then looked up an address in a geo-database, and took that verbatim, which is how we've ended up with these long addresses.

In practice, I don't think it'll be a problem in the future, and I'd rather leave it unbounded and have a few dodgy-looking info boxes than limit it and (potentially) lose information.