CSTACKEX-16 Print Location Type

Author: Gupta, Surya

engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java

@@ -112,11 +112,11 @@ public class StorageSystemSnapshotStrategy extends SnapshotStrategyBase {
     @Override
     public SnapshotInfo backupSnapshot(SnapshotInfo snapshotInfo) {
         logger.info("backupSnapshot snapshotInfo: {} ", snapshotInfo.toString());
+        logger.info("backupSnapshot snapshotInfo.getLocationType(): {} ", snapshotInfo.getLocationType());
         Preconditions.checkArgument(snapshotInfo != null, "'snapshotInfo' cannot be 'null'.");
 
-        if (snapshotInfo.getLocationType() != Snapshot.LocationType.SECONDARY) {
+        if (snapshotInfo.getLocationType() != null && snapshotInfo.getLocationType() != Snapshot.LocationType.SECONDARY) {
             markAsBackedUp((SnapshotObject)snapshotInfo);
-
             return snapshotInfo;
         }
 

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

@@ -303,6 +303,8 @@ public void copyAsync(DataObject srcData, DataObject destData, Host destHost, As
 
     @Override
     public boolean canCopy(DataObject srcData, DataObject destData) {
+        s_logger.info("canCopy: srcData: {}", srcData);
+        s_logger.info("canCopy: destData: {}", destData);
         return true;
     }
 
@@ -707,12 +709,9 @@ public void takeSnapshot(SnapshotInfo snapshot, AsyncCompletionCallback<CreateCm
         } catch (Exception ex) {
             s_logger.error("takeSnapshot: Failed due to ", ex);
             result = new CreateCmdResult(null, new CreateObjectAnswer(ex.toString()));
-
             result.setResult(ex.toString());
         }
-
         callback.complete(result);
-
     }
 
     private AccessGroup getAccessGroupRequestByProtocol(Map<String, String> poolDetails, String storagePoolUuid) {