Skip to content

Commit c1f0429

Browse files
Gupta, SuryaGupta, Surya
authored andcommitted
CSTACKEX-98 remove encoding and decoded the Base64 password
1 parent 185f2fb commit c1f0429

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -183,15 +183,12 @@ public DataStore initialize(Map<String, Object> dsInfos) {
183183
details.put(Constants.SIZE, capacityBytes.toString());
184184

185185
ProtocolType protocol = ProtocolType.valueOf(details.get(Constants.PROTOCOL));
186-
String encodedPassword = details.get(Constants.PASSWORD);
187-
byte[] decodedBytes = Base64.getDecoder().decode(encodedPassword);
188-
String decodedPassword = new String(decodedBytes);
189186

190187
// Connect to ONTAP and create volume
191188
long volumeSize = Long.parseLong(details.get(Constants.SIZE));
192189
OntapStorage ontapStorage = new OntapStorage(
193190
details.get(Constants.USERNAME),
194-
decodedPassword,
191+
details.get(Constants.PASSWORD),
195192
details.get(Constants.STORAGE_IP),
196193
details.get(Constants.SVM_NAME),
197194
volumeSize,

ui/src/views/infra/AddPrimaryStorage.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -938,7 +938,7 @@ export default {
938938
} else if (values.provider === 'ONTAP') {
939939
params['details[0].storage_ip'] = values.ontapIP
940940
params['details[0].username'] = values.ontapUsername
941-
params['details[0].password'] = btoa(values.ontapPassword)
941+
params['details[0].password'] = values.ontapPassword
942942
params['details[0].svmName'] = values.ontapSvmName
943943
params['details[0].protocol'] = values.protocol
944944
values.managed = true

0 commit comments

Comments
 (0)