bug: graphql-dgs-extended-validation returns IllegalStateException instead of validation exception in ExecutionResult of GraphQL Subscription #2119
Comments
Prototype-42
changed the title
|
Hi @Prototype-42 thanks for the reproducer. It doesn't looks like directives work within Subscriptions calls themselves. They do work on the mutations. The problem occurs because the graphql extended validations doesn't return Flux type on validation errors where as spring-graphql expects it in subscriptions, or expects a registered adapter for the type. It returns a DataFetcherResult. Here's where that happens. What does work is applying the I'll follow up with some potential updates to graphql-java to see what the best recommended fix could be. |
|
The only way I opened an issue in |
|
@iparadiso Thank you for your effort =) |
|
@Prototype-42 can you try now? I forgot to change it to public. |
Expected behavior
Actual behavior
java.lang.IllegalStateException: Expected Publisher for a subscriptionSteps to reproduce
Have a GraphQL Subscription with an input field that is annotated with a validation directive.
E.g.:
Then call the Subscription with an input parameter that conflicts with the validation directive.
E.g.:
Test case
GitHub Link
I created a test case where I checked for the correct behavior of the validations. On a mutation it works as expected and when the input parameter conforms with the validation on a Subscription there is also no issue.
I hope anyone can help me figuring out the problem here.
When you clone my test repo and try it out yourself you'll see that the third test fails.
While debugging, setting a breakpoint for any IllegalStateExceptions, you can see that the expected error message can be found in a
DataFetcherResultin theReactiveAdapterRegistryHelper.In the end however, the IllegalStateException is thrown by the
ReactiveAdapterbeingnull.Here is the console output for that test:
The text was updated successfully, but these errors were encountered: