Skip to content

Commit 9d435d5

Browse files
committed
feat: switched docker login credentials to oidc token
1 parent 621b1be commit 9d435d5

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

.github/workflows/pipeline-ci-pull-request.yaml

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,23 @@ jobs:
5454
echo "IMAGE_NAME=${IMAGE_NAME}" >> $GITHUB_ENV
5555
echo "IMAGE_TAG=${IMAGE_TAG}" >> $GITHUB_ENV
5656
57+
- name: Install JFrog CLI
58+
id: jfrog
59+
uses: jfrog/setup-jfrog-cli@v4
60+
env:
61+
JF_URL: ${{ vars.JFROG_URL }}
62+
JF_PROJECT: ${{ inputs.artifactory_project }}
63+
with:
64+
oidc-provider-name: github-nethermindeth
65+
5766
- name: Login to Docker Hub
5867
uses: docker/login-action@v3
5968
with:
6069
registry: ${{ vars.JFROG_HOST }}/${{ inputs.image_reportory }}
61-
username: ${{ secrets.registry_username }}
62-
password: ${{ secrets.registry_password }}
70+
username: ${{ steps.jfrog.outputs.oidc-user }}
71+
password: ${{ steps.jfrog.outputs.oidc-token }}
72+
# username: ${{ secrets.registry_username }}
73+
# password: ${{ secrets.registry_password }}
6374

6475
- name: Set up QEMU
6576
uses: docker/setup-qemu-action@v3
@@ -79,14 +90,6 @@ jobs:
7990
cache-from: type=gha
8091
cache-to: type=gha,mode=max
8192

82-
- name: Install JFrog CLI
83-
uses: jfrog/setup-jfrog-cli@v4
84-
env:
85-
JF_URL: ${{ vars.JFROG_URL }}
86-
JF_PROJECT: ${{ inputs.artifactory_project }}
87-
with:
88-
oidc-provider-name: github-nethermindeth
89-
9093
- name: JFrog build add context
9194
env:
9295
JFROG_CLI_BUILD_NAME: ${{ env.IMAGE_NAME }}

0 commit comments

Comments
 (0)