Remove nightly features (#24)

Author: v0-e

.github/workflows/ci.yml

@@ -48,6 +48,10 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: stable
+          override: true
       # use the more efficient nextest
       - uses: taiki-e/install-action@nextest
       - uses: Swatinem/rust-cache@v2
@@ -70,8 +74,12 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: stable
+          components: rustfmt
+          override: true
       - uses: Swatinem/rust-cache@v2
-      - run: rustup component add rustfmt
       - uses: actions-rs/cargo@v1
         with:
           command: fmt
@@ -85,6 +93,9 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
+          profile: minimal
+          toolchain: stable
+          override: true
           components: clippy
       - uses: Swatinem/rust-cache@v2
       - name: Run clippy

.github/workflows/linter.yml

@@ -15,6 +15,8 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions-rs/toolchain@v1
         with:
+          profile: minimal
+          toolchain: stable
           components: rustfmt, clippy
           override: true
 

.github/workflows/typos.toml

@@ -1,3 +1,3 @@
 [default.extend-words]
 nd = "nd"
-hax = "hax"
+hax = "hax"

crates/linear_algebra/src/lib.rs

@@ -1,7 +1,5 @@
 #![cfg_attr(not(feature = "std"), no_std)]
-#![feature(trait_alias)]
 #![allow(incomplete_features)]
-#![feature(inherent_associated_types)]
 
 #[macro_use]
 extern crate ark_std;

crates/ring/src/cyclotomic_ring/crt.rs

@@ -1,3 +1,4 @@
+use crate::utils::into_raw_parts;
 use ark_std::{ptr, slice, vec::*};
 
 /// Enables Chinese Remainder Transform (CRT) conversion from coefficient
@@ -7,7 +8,7 @@ pub trait CRT: Sized {
 
     fn crt(self) -> Self::CRTForm;
     fn elementwise_crt(vec: Vec<Self>) -> Vec<Self::CRTForm> {
-        let (ptr, len, cap) = vec.into_raw_parts();
+        let (ptr, len, cap) = into_raw_parts(vec);
 
         let slice = unsafe { slice::from_raw_parts_mut(ptr, len) };
 
@@ -31,7 +32,7 @@ pub trait ICRT: Sized {
 
     fn icrt(self) -> Self::ICRTForm;
     fn elementwise_icrt(vec: Vec<Self>) -> Vec<Self::ICRTForm> {
-        let (ptr, len, cap) = vec.into_raw_parts();
+        let (ptr, len, cap) = into_raw_parts(vec);
 
         let slice = unsafe { slice::from_raw_parts_mut(ptr, len) };
 

crates/ring/src/cyclotomic_ring/flatten.rs

@@ -2,7 +2,7 @@
 //! This module introduces a function `flatten_to_coeffs` on vectors of
 //! cyclotomic ring elements to cheaply cast them into vectors of corresponding
 //! base field coefficients and its "inverse" `promote_from_coeffs`.
-use crate::PolyRing;
+use crate::{utils::into_raw_parts, PolyRing};
 use ark_std::vec::*;
 
 use super::{CyclotomicConfig, CyclotomicPolyRingGeneral, CyclotomicPolyRingNTTGeneral};
@@ -11,7 +11,7 @@ pub trait Flatten: PolyRing {
     fn flatten_to_coeffs(vec: Vec<Self>) -> Vec<Self::BaseRing> {
         let dimension = Self::dimension();
 
-        let (ptr, len, cap) = vec.into_raw_parts();
+        let (ptr, len, cap) = into_raw_parts(vec);
 
         unsafe { Vec::from_raw_parts(ptr as *mut Self::BaseRing, len * dimension, cap * dimension) }
     }
@@ -27,7 +27,7 @@ pub trait Flatten: PolyRing {
             vec.shrink_to_fit();
         }
 
-        let (ptr, len, cap) = vec.into_raw_parts();
+        let (ptr, len, cap) = into_raw_parts(vec);
 
         Some(unsafe { Vec::from_raw_parts(ptr as *mut Self, len / dimension, cap / dimension) })
     }

crates/ring/src/cyclotomic_ring/models/babybear/fq9.rs

@@ -2,6 +2,7 @@ use ark_ff::{CubicExtConfig, CubicExtField, Fp3, Fp3Config, SqrtPrecomputation};
 use ark_std::{marker::PhantomData, vec::*};
 
 use super::{BabyBear3ExtConfig, Fq, Fq9};
+use crate::utils::into_raw_parts;
 
 pub trait Fp9Config: 'static + Send + Sync + Sized {
     type Fp3Config: Fp3Config;
@@ -60,7 +61,7 @@ pub type Fp9<P> = CubicExtField<Fp9ConfigWrapper<P>>;
 pub(super) fn fq_vec_to_fq9_vec(mut vec: Vec<Fq>) -> Vec<Fq9> {
     vec.shrink_to_fit();
 
-    let (ptr, len, cap) = vec.into_raw_parts();
+    let (ptr, len, cap) = into_raw_parts(vec);
 
     assert_eq!(len, cap);
 
@@ -70,7 +71,7 @@ pub(super) fn fq_vec_to_fq9_vec(mut vec: Vec<Fq>) -> Vec<Fq9> {
 pub(super) fn fq9_vec_to_fq_vec(mut vec: Vec<Fq9>) -> Vec<Fq> {
     vec.shrink_to_fit();
 
-    let (ptr, len, cap) = vec.into_raw_parts();
+    let (ptr, len, cap) = into_raw_parts(vec);
 
     assert_eq!(len, cap);
 

crates/ring/src/cyclotomic_ring/models/frog_ring/utils.rs

@@ -1,10 +1,11 @@
 use super::{Fq, Fq4};
+use crate::utils::into_raw_parts;
 use ark_std::vec::*;
 
 pub(super) fn fq_vec_to_fq4_vec(mut vec: Vec<Fq>) -> Vec<Fq4> {
     vec.shrink_to_fit();
 
-    let (ptr, len, cap) = vec.into_raw_parts();
+    let (ptr, len, cap) = into_raw_parts(vec);
 
     assert_eq!(len, cap);
 
@@ -14,7 +15,7 @@ pub(super) fn fq_vec_to_fq4_vec(mut vec: Vec<Fq>) -> Vec<Fq4> {
 pub(super) fn fq4_vec_to_fq_vec(mut vec: Vec<Fq4>) -> Vec<Fq> {
     vec.shrink_to_fit();
 
-    let (ptr, len, cap) = vec.into_raw_parts();
+    let (ptr, len, cap) = into_raw_parts(vec);
 
     assert_eq!(len, cap);
 

crates/ring/src/cyclotomic_ring/models/goldilocks/utils.rs

@@ -1,10 +1,11 @@
 use super::{Fq, Fq3};
+use crate::utils::into_raw_parts;
 use ark_std::vec::*;
 
 pub(super) fn fq_vec_to_fq3_vec(mut vec: Vec<Fq>) -> Vec<Fq3> {
     vec.shrink_to_fit();
 
-    let (ptr, len, cap) = vec.into_raw_parts();
+    let (ptr, len, cap) = into_raw_parts(vec);
 
     assert_eq!(len, cap);
 
@@ -14,7 +15,7 @@ pub(super) fn fq_vec_to_fq3_vec(mut vec: Vec<Fq>) -> Vec<Fq3> {
 pub(super) fn fq3_vec_to_fq_vec(mut vec: Vec<Fq3>) -> Vec<Fq> {
     vec.shrink_to_fit();
 
-    let (ptr, len, cap) = vec.into_raw_parts();
+    let (ptr, len, cap) = into_raw_parts(vec);
 
     assert_eq!(len, cap);
 

crates/ring/src/lib.rs

@@ -1,6 +1,5 @@
 #![cfg_attr(not(feature = "std"), no_std)]
 #![allow(non_snake_case)]
-#![feature(vec_into_raw_parts)]
 // Exports
 pub use balanced_decomposition::{
     representatives::{SignedRepresentative, UnsignedRepresentative},
@@ -20,6 +19,7 @@ mod error;
 mod monomial;
 mod poly_ring;
 mod ring;
+pub(crate) mod utils;
 
 #[macro_use]
 extern crate ark_std;