Reconcile TotalDeposits with share-based TotalAssets after yield

[devsimze]

Problem

TotalDeposits tracks principal while TotalAssets includes yield. After update_total_assets(), TVL cap checks and get_total_deposits() can disagree with share pricing.

Scope

• deposit, withdraw, update_total_assets, cap guards

Acceptance criteria

• Document the relationship between TotalDeposits, TotalAssets, and shares.
• Either sync TotalDeposits on yield updates or stop using it for caps where TotalAssets is correct.
• Regression tests for deposit → yield → withdraw → cap check.

[OpensrcLord]

@Zeemnew has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Hello @maintainer, I’ve gone through the requirements and I’m confident I can implement a proper solution that matches the acceptance criteria. Kindly assign this issue to me. And I will deliver at the shortest possible time.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Zeemnew to this issue.

[Mrwicks00]

@Mrwicks00 has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Hi! I'd like to work on this issue.

I have experience with the relevant technologies and understand the requirements. I can submit a clean solution and keep the PR focused on the requested changes.

Could you please assign it to me? Thanks!

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Mrwicks00 to this issue.

[drips-wave]

Congratulations, @Mrwicks00! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 30, 2026.

🧑‍💻 @Mrwicks00: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[grantfox-oss]

🦊 GrantFox — @Mrwicks00 has been assigned to this issue as part of the Official Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #299)
2. Your PR will be reviewed by the Neurowealth maintainers

Good luck! Track your progress on GrantFox.

[drips-wave]

This issue has been completed by @Mrwicks00 as part of the Stellar Wave Program's 6th Wave 🥳

😎 @Mrwicks00: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.