Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reload parameter from notepad #15

Open
NickSto opened this issue Jul 10, 2022 · 1 comment
Open

Remove reload parameter from notepad #15

NickSto opened this issue Jul 10, 2022 · 1 comment
Labels

Comments

@NickSto
Copy link
Owner

NickSto commented Jul 10, 2022

The reload url parameter on the notepad app is used in the "select all" and "select none" buttons. And it looks might finally be trapping some crawlers in loops (see visits from this ip).

It'd be great to remove that kludge. But it does serve a purpose (see 4ddb5ab) in the situation where a user clicks "select all", then unchecks some boxes, then decides to "select all" again. Without the reload parameter, the button goes to the same url they're currently on, so the browser won't load the page again, leaving those boxes unchecked and breaking the functionality of the "select all" button.

I think changing it to a POST request might work.

@NickSto NickSto added the bug label Jul 10, 2022
NickSto added a commit that referenced this issue Aug 31, 2022
- Addresses #15
  - But leaves the underlying problem the parameter solved unresolved.
@NickSto
Copy link
Owner Author

NickSto commented Aug 31, 2022

Update: Removed with 7596a90, but without a replacement solution for the problem it was solving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant