Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when End Of Life #9556

Open
roberth opened this issue Dec 7, 2023 · 6 comments
Open

Warn when End Of Life #9556

roberth opened this issue Dec 7, 2023 · 6 comments
Labels
error-messages Confusing messages and better diagnostics feature Feature request or proposal idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. process Issues related to the development process of Nix

Comments

@roberth
Copy link
Member

roberth commented Dec 7, 2023

Is your feature request related to a problem? Please describe.

Sometimes users find themselves running an old version. Possibly only after a long and unnecessary debugging session.

Describe the solution you'd like

  • When the current time is larger than the planned end-of-life date of a Nix release, print a warning.

Warnings can be annoying.

  • Perhaps only print a warning once a day.
  • Allow the warning to be disabled with a setting.

Warnings will throw off the test suite

  • Disable the warning in the functional tests.

Experimental features suffer more significantly from this problem.

  • Perhaps go EOL sooner if experimental features are enabled.
    • I believe we might not be ready to support such a release cadence confidently, but perhaps in a year or two we may.

Describe alternatives you've considered

  • Don't help users with upgrading
  • Only enable the warning when the official installer is used. E.g. NixOS should nag on its own.
  • Brown-outs

Additional context

Priorities

Add 👍 to issues you find important.

@roberth roberth added feature Feature request or proposal error-messages Confusing messages and better diagnostics process Issues related to the development process of Nix labels Dec 7, 2023
@roberth roberth added this to Nix team Dec 7, 2023
@roberth roberth changed the title Nag when End Of Life Warn when End Of Life Dec 7, 2023
@thufschmitt
Copy link
Member

That sounds like a fairly good idea.

We probably want to give it a bit of slack wrt the eol date (if only because we'll have to embed it in the binary, and we can't predict the future), but that sounds like a cheap and worthwhile thing to do.

Only enable the warning when the official installer is used. E.g. NixOS should nag on its own.

If we make this configurable with a configuration option (which we should probably do), then it's just up to the NixOS maintainers to set the right option

Experimental features suffer more significantly from this problem.

* Perhaps go EOL sooner if experimental features are enabled.
  
  * I believe we might not be ready to support such a release cadence confidently, but perhaps in a year or two we may.

I still hope that we can get (again) to the point were a broad 99% of the Nix users can live without experimental features, in which case this case would mostly solve itself

@roberth
Copy link
Member Author

roberth commented Dec 7, 2023

slack wrt the eol date

Patch releases should be sufficient to propagate a postponement. If users don't catch patch updates, they have a security problem. (Not necessarily from Nix, but from their lack of general updates)

users [should be able to] live without experimental features

Exactly. When we're there, we can have an "experimental EOL" that's shorter than normal EOL.

Thinking again, I kind of like the idea of pushing flake users on 23.11 to update in 3 months from now when a bunch of stuff needs broad testing. Realistically, it seems that nixos-unstable users will be sufficient for experimental testing.

@thufschmitt thufschmitt moved this to ⚖ To discuss in Nix team Dec 8, 2023
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-12-08-nix-team-meeting-minutes-110/36721/1

@tpwrules
Copy link
Contributor

I have found this very annoying when using some other software and would strongly disagree with adding it. I deploy Nix (and that other software) to static systems that aren't really expected to be upgraded on a fixed schedule and having these messages pop up harms users. If it's added, there must be an option to unconditionally disable it.

@thufschmitt thufschmitt added the idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. label Jan 12, 2024
@thufschmitt thufschmitt removed the status in Nix team Jan 12, 2024
@thufschmitt
Copy link
Member

Discussed during the Nix maintenance team meeting on 2024-01-12. Morally approved

- @thufschmitt in support provided there's a flag to disable that behavior - @edolstra a bit meh, but not really opposed - @roberth: We can start very flexible (one year), just to rule out very old stuff

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2021-01-11-nix-team-meeting-minutes-115/38277/1

@edolstra edolstra removed this from Nix team Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error-messages Confusing messages and better diagnostics feature Feature request or proposal idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. process Issues related to the development process of Nix
Projects
None yet
Development

No branches or pull requests

4 participants