Skip to content

hiredis is not compiling in nodejs 12 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rj-david opened this issue Jul 7, 2019 · 7 comments
Closed

hiredis is not compiling in nodejs 12 #53

rj-david opened this issue Jul 7, 2019 · 7 comments

Comments

@rj-david
Copy link

rj-david commented Jul 7, 2019

Is there any way that this package will no longer depend on hiredis? Hiredis is not building properly using node-gyp in nodejs 12

@stelcodes
Copy link

I'm getting the same issue when building with parcel

@sookoll
Copy link

sookoll commented Sep 17, 2019

Any news on this? As hiredis is pretty much abonded, it should be removed as dependency.

EDIT: Ah, v3 it is removed already, node-redis still uses 2.6 and that was causing problems.

@swateek
Copy link

swateek commented Nov 7, 2019

@sookoll could you install "redis"? I didn't quite understand your solution. Help?

@yosiat
Copy link

yosiat commented Nov 17, 2019

If you can upgrade the latest node-redis you don't need hiredis, it uses this repo which is fastest than hiredis as authors claim.

If you are like me and stuck at some version, you can use this fork redis/hiredis-node#144 until the PR will get merged

@swateek
Copy link

swateek commented Nov 18, 2019

I really didn't need hiredis. I moved to use "ioredis" and it works good for me.

@Salakar
Copy link
Member

Salakar commented Feb 5, 2020

Hey all,

hiredis is no longer used in the latest parser, the the redis library has been updated to the latest parser version in redis/node-redis@78936ac (unreleased still, no eta).

Given that a fix is sat on master for this I'm going to go ahead and close this issue now. Thanks

@ropre4
Copy link

ropre4 commented Jun 7, 2021

It's been more than a year, can there be a new release to include this fix? redis-parser, and redis packages do not work on node 12 and node 14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants