Build and edit in Shakespeare#1
Open
marykatefain wants to merge 5 commits into
Open
Conversation
- Change Vite base from '/bunch/' to './' for relative paths - Update favicon paths in index.html to be relative - Simplify 404.html redirect for client-side routing - Remove BrowserRouter basename (use root path) - Update redirect handling to use sessionStorage
- Replace BASE_URL reference in logo src with absolute path /logo-name.png - Simplify customer view button to use absolute path /customer - Removes undefined prefix issue in image sources
- Add build:github script for GitHub Pages deployment with /bunch/ base - Update vite.config to use mode-based base path (github mode vs default) - Create paths utility (getAssetPath, getRoutePath) for environment-aware URLs - Update MerchantApp to use path utilities for logo and customer view link - Update 404.html redirect to handle both root and /bunch/ base paths - Update GitHub Actions workflow to use build:github script Now supports: - Shakespeare: base ./ (relative paths, root deployment) - GitHub Pages: base /bunch/ (absolute paths with prefix)
- Add fallback for undefined BASE_URL - Use optional chaining for endsWith call - Prevents "Cannot read properties of undefined" error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview it here: https://bunch-app.shakespeare.wtf/