From 029a92172e3623207ef457ce513255746ed98134 Mon Sep 17 00:00:00 2001 From: atg Date: Thu, 7 May 2026 17:15:56 +0200 Subject: [PATCH] [ADD] sale_financial_risk_exclude_order_type: add risk controls by order type This module extends sale_financial_risk to support financial risk behavior configuration directly on sale order types. It allows configuring sale order types to: - exclude orders from risk computation - bypass financial risk blocking validation The implementation intentionally integrates the behavior directly into sale.order.type in order to: - simplify the architecture - avoid unnecessary configuration models - reduce maintenance complexity - align configuration with business semantics Features: - risk computation exclusion by order type - blocking bypass support by order type - independent control of computation and blocking - multi-company compatible behavior - integration with sale_order_type Technical details: - extends sale.order.type - overrides evaluate_risk_message - extends risk computation domain - preserves standard sale_financial_risk behavior Includes automated tests for: - blocking bypass behavior - risk domain generation - separation of concerns - neutral order types - multi-company behavior - domain integrity --- .../README.rst | 148 ++++++ .../__init__.py | 1 + .../__manifest__.py | 20 + .../i18n/es.po | 64 +++ .../models/__init__.py | 3 + .../models/res_partner.py | 28 + .../models/sale_order.py | 27 + .../models/sale_order_type.py | 20 + .../pyproject.toml | 3 + .../readme/CONFIGURATION.md | 11 + .../readme/CONTRIBUTORS.md | 2 + .../readme/DESCRIPTION.md | 39 ++ .../readme/ROADMAP.md | 5 + .../readme/TESTS.md | 11 + .../readme/USAGE.md | 15 + .../static/description/icon.png | Bin 0 -> 9455 bytes .../static/description/index.html | 485 ++++++++++++++++++ .../tests/__init__.py | 1 + ..._sale_financial_risk_exclude_order_type.py | 264 ++++++++++ .../views/sale_order_type_views.xml | 21 + 20 files changed, 1168 insertions(+) create mode 100644 sale_financial_risk_exclude_order_type/README.rst create mode 100644 sale_financial_risk_exclude_order_type/__init__.py create mode 100644 sale_financial_risk_exclude_order_type/__manifest__.py create mode 100644 sale_financial_risk_exclude_order_type/i18n/es.po create mode 100644 sale_financial_risk_exclude_order_type/models/__init__.py create mode 100644 sale_financial_risk_exclude_order_type/models/res_partner.py create mode 100644 sale_financial_risk_exclude_order_type/models/sale_order.py create mode 100644 sale_financial_risk_exclude_order_type/models/sale_order_type.py create mode 100644 sale_financial_risk_exclude_order_type/pyproject.toml create mode 100644 sale_financial_risk_exclude_order_type/readme/CONFIGURATION.md create mode 100644 sale_financial_risk_exclude_order_type/readme/CONTRIBUTORS.md create mode 100644 sale_financial_risk_exclude_order_type/readme/DESCRIPTION.md create mode 100644 sale_financial_risk_exclude_order_type/readme/ROADMAP.md create mode 100644 sale_financial_risk_exclude_order_type/readme/TESTS.md create mode 100644 sale_financial_risk_exclude_order_type/readme/USAGE.md create mode 100644 sale_financial_risk_exclude_order_type/static/description/icon.png create mode 100644 sale_financial_risk_exclude_order_type/static/description/index.html create mode 100644 sale_financial_risk_exclude_order_type/tests/__init__.py create mode 100644 sale_financial_risk_exclude_order_type/tests/test_sale_financial_risk_exclude_order_type.py create mode 100644 sale_financial_risk_exclude_order_type/views/sale_order_type_views.xml diff --git a/sale_financial_risk_exclude_order_type/README.rst b/sale_financial_risk_exclude_order_type/README.rst new file mode 100644 index 000000000..1c75edcfc --- /dev/null +++ b/sale_financial_risk_exclude_order_type/README.rst @@ -0,0 +1,148 @@ +====================================== +Sale Financial Risk Exclude Order Type +====================================== + +.. + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! source digest: sha256:f47c700d76bb1d6eda697be06e36a973c16d1b9409211b4a17653209e388ee74 + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Alpha-red.png + :target: https://odoo-community.org/page/development-status + :alt: Alpha +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fcredit--control-lightgray.png?logo=github + :target: https://github.com/OCA/credit-control/tree/17.0/sale_financial_risk_exclude_order_type + :alt: OCA/credit-control +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/credit-control-17-0/credit-control-17-0-sale_financial_risk_exclude_order_type + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png + :target: https://runboat.odoo-community.org/builds?repo=OCA/credit-control&target_branch=17.0 + :alt: Try me on Runboat + +|badge1| |badge2| |badge3| |badge4| |badge5| + +This module extends ``sale.order.type`` to integrate with +``sale_financial_risk``. + +It adds two independent behaviors to sale order types: + +- Exclude orders from financial risk computation +- Allow confirmation bypass for financial risk blocking + +This allows implementing flexible commercial workflows while keeping the +standard financial risk framework intact. + +Features +======== + +- Extend ``sale.order.type`` with financial risk options +- Exclude selected order types from risk exposure computation +- Allow selected order types to bypass financial risk blocking +- Keep computation and blocking behaviors independent +- Compatible with ``sale_financial_risk`` +- Compatible with multi-company environments + +Design Notes +============ + +This module intentionally keeps the financial risk behavior directly +attached to ``sale.order.type``. + +The implementation avoids introducing additional rule or configuration +models in order to: + +- keep the behavior simple +- reduce maintenance complexity +- align with the functional nature of sale order types +- avoid unnecessary configuration layers + +The module still preserves separation between: + +- financial exposure computation +- confirmation blocking behavior + +.. IMPORTANT:: + This is an alpha version, the data model and design can change at any time without warning. + Only for development or testing purpose, do not use in production. + `More details on development status `_ + +**Table of contents** + +.. contents:: + :local: + +Usage +===== + +Usage +===== + +- Exclude from Risk Computation + +Sale orders using this type will not contribute to the partner financial +exposure calculation. + +- Allow Risk Blocking Bypass + +Sale orders using this type can be confirmed even when financial risk +blocking would normally prevent confirmation. + +Both options are independent and can be combined freely. + +Known issues / Roadmap +====================== + +Known issues / Roadmap +====================== + +- Add optional risk warning indicators on sale orders +- Improve reporting of excluded order types + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +------- + +* Binhex Systems Solutions S.L + +Contributors +------------ + +- `Binhex Systems Solutions S.L. `__: + + - Ariel Torres + +Maintainers +----------- + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +This module is part of the `OCA/credit-control `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/sale_financial_risk_exclude_order_type/__init__.py b/sale_financial_risk_exclude_order_type/__init__.py new file mode 100644 index 000000000..0650744f6 --- /dev/null +++ b/sale_financial_risk_exclude_order_type/__init__.py @@ -0,0 +1 @@ +from . import models diff --git a/sale_financial_risk_exclude_order_type/__manifest__.py b/sale_financial_risk_exclude_order_type/__manifest__.py new file mode 100644 index 000000000..a1ccc55d3 --- /dev/null +++ b/sale_financial_risk_exclude_order_type/__manifest__.py @@ -0,0 +1,20 @@ +{ + "name": "Sale Financial Risk Exclude Order Type", + "summary": "Exclude sale order types from financial risk computation", + "version": "17.0.1.0.0", + "category": "Credit Control", + "author": "Binhex Systems Solutions S.L, Odoo Community Association (OCA)", + "website": "https://github.com/OCA/credit-control", + "license": "AGPL-3", + "depends": [ + "sale_financial_risk", + "sale_order_type", + ], + "data": [ + "views/sale_order_type_views.xml", + ], + "images": ["static/description/icon.png"], + "installable": True, + "application": False, + "development_status": "Alpha", +} diff --git a/sale_financial_risk_exclude_order_type/i18n/es.po b/sale_financial_risk_exclude_order_type/i18n/es.po new file mode 100644 index 000000000..6e9958a92 --- /dev/null +++ b/sale_financial_risk_exclude_order_type/i18n/es.po @@ -0,0 +1,64 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * sale_financial_risk_exclude_order_type +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 17.0\n" +"Report-Msgid-Bugs-To: \n" +"POT-Creation-Date: 2026-04-23 07:27+0000\n" +"PO-Revision-Date: 2026-04-23 07:27+0000\n" +"Last-Translator: \n" +"Language-Team: \n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: \n" + +#. module: sale_financial_risk_exclude_order_type +#: model:ir.model.fields,field_description:sale_financial_risk_exclude_order_type.field_sale_order_type__allow_blocking_bypass +msgid "Allow Risk Blocking Bypass" +msgstr "Permitir omitir bloqueo de riesgo" + +#. module: sale_financial_risk_exclude_order_type +#: model:ir.model,name:sale_financial_risk_exclude_order_type.model_res_partner +msgid "Contact" +msgstr "Contacto" + +#. module: sale_financial_risk_exclude_order_type +#: model:ir.model.fields,field_description:sale_financial_risk_exclude_order_type.field_sale_order_type__exclude_from_risk +msgid "Exclude from Risk Computation" +msgstr "Excluir del cálculo de riesgo" + +#. module: sale_financial_risk_exclude_order_type +#: model_terms:ir.ui.view,arch_db:sale_financial_risk_exclude_order_type.sale_order_type_view_form_inherit_sale_financial_risk_exclude_order_type +msgid "Financial Risk" +msgstr "Riesgo financiero" + +#. module: sale_financial_risk_exclude_order_type +#: model:ir.model.fields,help:sale_financial_risk_exclude_order_type.field_sale_order_type__exclude_from_risk +msgid "" +"If enabled, sale orders of this type are excluded from sale financial risk " +"computation." +msgstr "" +"Si está habilitado, los pedidos de venta de este tipo se excluyen del cálculo " +"del riesgo financiero de venta." + +#. module: sale_financial_risk_exclude_order_type +#: model:ir.model.fields,help:sale_financial_risk_exclude_order_type.field_sale_order_type__allow_blocking_bypass +msgid "" +"If enabled, sale orders of this type can be confirmed without financial risk" +" blocking." +msgstr "" +"Si está habilitado, los pedidos de venta de este tipo se pueden confirmar " +"sin bloqueo por riesgo financiero. " + +#. module: sale_financial_risk_exclude_order_type +#: model:ir.model,name:sale_financial_risk_exclude_order_type.model_sale_order +msgid "Sales Order" +msgstr "Pedido de venta" + +#. module: sale_financial_risk_exclude_order_type +#: model:ir.model,name:sale_financial_risk_exclude_order_type.model_sale_order_type +msgid "Type of sale order" +msgstr "Tipo de pedido de venta" diff --git a/sale_financial_risk_exclude_order_type/models/__init__.py b/sale_financial_risk_exclude_order_type/models/__init__.py new file mode 100644 index 000000000..54c46f430 --- /dev/null +++ b/sale_financial_risk_exclude_order_type/models/__init__.py @@ -0,0 +1,3 @@ +from . import sale_order_type +from . import res_partner +from . import sale_order diff --git a/sale_financial_risk_exclude_order_type/models/res_partner.py b/sale_financial_risk_exclude_order_type/models/res_partner.py new file mode 100644 index 000000000..778a1da38 --- /dev/null +++ b/sale_financial_risk_exclude_order_type/models/res_partner.py @@ -0,0 +1,28 @@ +from odoo import models + + +class ResPartner(models.Model): + _inherit = "res.partner" + + def _get_risk_sale_order_domain(self): + """ + Extend the domain used by sale_financial_risk to compute + sale order exposure. + Since the base computation runs on sale.order.line, the related + field path used here is: + order_id.type_id + """ + domain = super()._get_risk_sale_order_domain() + excluded_types = self.env["sale.order.type"].search( + [ + ("exclude_from_risk", "=", True), + "|", + ("company_id", "=", False), + ("company_id", "=", self.env.company.id), + ] + ) + + if excluded_types: + domain += [("order_id.type_id", "not in", excluded_types.ids)] + + return domain diff --git a/sale_financial_risk_exclude_order_type/models/sale_order.py b/sale_financial_risk_exclude_order_type/models/sale_order.py new file mode 100644 index 000000000..576f15c3c --- /dev/null +++ b/sale_financial_risk_exclude_order_type/models/sale_order.py @@ -0,0 +1,27 @@ +from odoo import models + + +class SaleOrder(models.Model): + _inherit = "sale.order" + + def _allow_financial_risk_blocking_bypass(self): + """ + Return whether this order type is configured to bypass + financial risk blocking. + """ + self.ensure_one() + return bool(self.type_id and self.type_id.allow_blocking_bypass) + + def evaluate_risk_message(self, partner): + """ + Override the blocking decision from sale_financial_risk. + If the order type is configured with 'Allow Risk Blocking Bypass', + no blocking message is returned. + Otherwise, preserve the standard behavior. + """ + self.ensure_one() + + if self._allow_financial_risk_blocking_bypass(): + return False + + return super().evaluate_risk_message(partner) diff --git a/sale_financial_risk_exclude_order_type/models/sale_order_type.py b/sale_financial_risk_exclude_order_type/models/sale_order_type.py new file mode 100644 index 000000000..0020a4d03 --- /dev/null +++ b/sale_financial_risk_exclude_order_type/models/sale_order_type.py @@ -0,0 +1,20 @@ +from odoo import fields, models + + +class SaleOrderType(models.Model): + _inherit = "sale.order.type" + + exclude_from_risk = fields.Boolean( + string="Exclude from Risk Computation", + help=( + "If enabled, sale orders of this type are excluded from " + "sale financial risk computation." + ), + ) + allow_blocking_bypass = fields.Boolean( + string="Allow Risk Blocking Bypass", + help=( + "If enabled, sale orders of this type can be confirmed " + "without financial risk blocking." + ), + ) diff --git a/sale_financial_risk_exclude_order_type/pyproject.toml b/sale_financial_risk_exclude_order_type/pyproject.toml new file mode 100644 index 000000000..4231d0ccc --- /dev/null +++ b/sale_financial_risk_exclude_order_type/pyproject.toml @@ -0,0 +1,3 @@ +[build-system] +requires = ["whool"] +build-backend = "whool.buildapi" diff --git a/sale_financial_risk_exclude_order_type/readme/CONFIGURATION.md b/sale_financial_risk_exclude_order_type/readme/CONFIGURATION.md new file mode 100644 index 000000000..50c002be7 --- /dev/null +++ b/sale_financial_risk_exclude_order_type/readme/CONFIGURATION.md @@ -0,0 +1,11 @@ +To configure the module: + +Go to: + +*Sales > Configuration > Sale Order Types* + +For each order type you can configure: + +- *Exclude from Risk Computation* + +- *Allow Risk Blocking Bypass* diff --git a/sale_financial_risk_exclude_order_type/readme/CONTRIBUTORS.md b/sale_financial_risk_exclude_order_type/readme/CONTRIBUTORS.md new file mode 100644 index 000000000..84faefa7a --- /dev/null +++ b/sale_financial_risk_exclude_order_type/readme/CONTRIBUTORS.md @@ -0,0 +1,2 @@ +- [Binhex Systems Solutions S.L.](https://www.binhex.cloud): + - Ariel Torres diff --git a/sale_financial_risk_exclude_order_type/readme/DESCRIPTION.md b/sale_financial_risk_exclude_order_type/readme/DESCRIPTION.md new file mode 100644 index 000000000..74be736e3 --- /dev/null +++ b/sale_financial_risk_exclude_order_type/readme/DESCRIPTION.md @@ -0,0 +1,39 @@ +This module extends ``sale.order.type`` to integrate with +``sale_financial_risk``. + +It adds two independent behaviors to sale order types: + +- Exclude orders from financial risk computation +- Allow confirmation bypass for financial risk blocking + +This allows implementing flexible commercial workflows while +keeping the standard financial risk framework intact. + +Features +======== + +- Extend ``sale.order.type`` with financial risk options +- Exclude selected order types from risk exposure computation +- Allow selected order types to bypass financial risk blocking +- Keep computation and blocking behaviors independent +- Compatible with ``sale_financial_risk`` +- Compatible with multi-company environments + +Design Notes +============ + +This module intentionally keeps the financial risk behavior +directly attached to ``sale.order.type``. + +The implementation avoids introducing additional rule or +configuration models in order to: + +- keep the behavior simple +- reduce maintenance complexity +- align with the functional nature of sale order types +- avoid unnecessary configuration layers + +The module still preserves separation between: + +- financial exposure computation +- confirmation blocking behavior diff --git a/sale_financial_risk_exclude_order_type/readme/ROADMAP.md b/sale_financial_risk_exclude_order_type/readme/ROADMAP.md new file mode 100644 index 000000000..6e0d59996 --- /dev/null +++ b/sale_financial_risk_exclude_order_type/readme/ROADMAP.md @@ -0,0 +1,5 @@ +Known issues / Roadmap +====================== + +- Add optional risk warning indicators on sale orders +- Improve reporting of excluded order types diff --git a/sale_financial_risk_exclude_order_type/readme/TESTS.md b/sale_financial_risk_exclude_order_type/readme/TESTS.md new file mode 100644 index 000000000..cb152e697 --- /dev/null +++ b/sale_financial_risk_exclude_order_type/readme/TESTS.md @@ -0,0 +1,11 @@ +Testing +======= + +Includes automated tests covering: + +- risk computation exclusion +- blocking bypass behavior +- separation of concerns +- multi-company behavior +- neutral order types +- domain integrity \ No newline at end of file diff --git a/sale_financial_risk_exclude_order_type/readme/USAGE.md b/sale_financial_risk_exclude_order_type/readme/USAGE.md new file mode 100644 index 000000000..f232e5b5f --- /dev/null +++ b/sale_financial_risk_exclude_order_type/readme/USAGE.md @@ -0,0 +1,15 @@ +Usage +===== + +- Exclude from Risk Computation + +Sale orders using this type will not contribute to the +partner financial exposure calculation. + + +- Allow Risk Blocking Bypass + +Sale orders using this type can be confirmed even when +financial risk blocking would normally prevent confirmation. + +Both options are independent and can be combined freely. diff --git a/sale_financial_risk_exclude_order_type/static/description/icon.png b/sale_financial_risk_exclude_order_type/static/description/icon.png new file mode 100644 index 0000000000000000000000000000000000000000..3a0328b516c4980e8e44cdb63fd945757ddd132d GIT binary patch literal 9455 zcmW++2RxMjAAjx~&dlBk9S+%}OXg)AGE&Cb*&}d0jUxM@u(PQx^-s)697TX`ehR4?GS^qbkof1cslKgkU)h65qZ9Oc=ml_0temigYLJfnz{IDzUf>bGs4N!v3=Z3jMq&A#7%rM5eQ#dc?k~! zVpnB`o+K7|Al`Q_U;eD$B zfJtP*jH`siUq~{KE)`jP2|#TUEFGRryE2`i0**z#*^6~AI|YzIWy$Cu#CSLW3q=GA z6`?GZymC;dCPk~rBS%eCb`5OLr;RUZ;D`}um=H)BfVIq%7VhiMr)_#G0N#zrNH|__ zc+blN2UAB0=617@>_u;MPHN;P;N#YoE=)R#i$k_`UAA>WWCcEVMh~L_ zj--gtp&|K1#58Yz*AHCTMziU1Jzt_jG0I@qAOHsk$2}yTmVkBp_eHuY$A9)>P6o~I z%aQ?!(GqeQ-Y+b0I(m9pwgi(IIZZzsbMv+9w{PFtd_<_(LA~0H(xz{=FhLB@(1&qHA5EJw1>>=%q2f&^X>IQ{!GJ4e9U z&KlB)z(84HmNgm2hg2C0>WM{E(DdPr+EeU_N@57;PC2&DmGFW_9kP&%?X4}+xWi)( z;)z%wI5>D4a*5XwD)P--sPkoY(a~WBw;E~AW`Yue4kFa^LM3X`8x|}ZUeMnqr}>kH zG%WWW>3ml$Yez?i%)2pbKPI7?5o?hydokgQyZsNEr{a|mLdt;X2TX(#B1j35xPnPW z*bMSSOauW>o;*=kO8ojw91VX!qoOQb)zHJ!odWB}d+*K?#sY_jqPdg{Sm2HdYzdEx zOGVPhVRTGPtv0o}RfVP;Nd(|CB)I;*t&QO8h zFfekr30S!-LHmV_Su-W+rEwYXJ^;6&3|L$mMC8*bQptyOo9;>Qb9Q9`ySe3%V$A*9 zeKEe+b0{#KWGp$F+tga)0RtI)nhMa-K@JS}2krK~n8vJ=Ngm?R!9G<~RyuU0d?nz# z-5EK$o(!F?hmX*2Yt6+coY`6jGbb7tF#6nHA zuKk=GGJ;ZwON1iAfG$E#Y7MnZVmrY|j0eVI(DN_MNFJmyZ|;w4tf@=CCDZ#5N_0K= z$;R~bbk?}TpfDjfB&aiQ$VA}s?P}xPERJG{kxk5~R`iRS(SK5d+Xs9swCozZISbnS zk!)I0>t=A<-^z(cmSFz3=jZ23u13X><0b)P)^1T_))Kr`e!-pb#q&J*Q`p+B6la%C zuVl&0duN<;uOsB3%T9Fp8t{ED108<+W(nOZd?gDnfNBC3>M8WE61$So|P zVvqH0SNtDTcsUdzaMDpT=Ty0pDHHNL@Z0w$Y`XO z2M-_r1S+GaH%pz#Uy0*w$Vdl=X=rQXEzO}d6J^R6zjM1u&c9vYLvLp?W7w(?np9x1 zE_0JSAJCPB%i7p*Wvg)pn5T`8k3-uR?*NT|J`eS#_#54p>!p(mLDvmc-3o0mX*mp_ zN*AeS<>#^-{S%W<*mz^!X$w_2dHWpcJ6^j64qFBft-o}o_Vx80o0>}Du;>kLts;$8 zC`7q$QI(dKYG`Wa8#wl@V4jVWBRGQ@1dr-hstpQL)Tl+aqVpGpbSfN>5i&QMXfiZ> zaA?T1VGe?rpQ@;+pkrVdd{klI&jVS@I5_iz!=UMpTsa~mBga?1r}aRBm1WS;TT*s0f0lY=JBl66Upy)-k4J}lh=P^8(SXk~0xW=T9v*B|gzIhN z>qsO7dFd~mgxAy4V?&)=5ieYq?zi?ZEoj)&2o)RLy=@hbCRcfT5jigwtQGE{L*8<@Yd{zg;CsL5mvzfDY}P-wos_6PfprFVaeqNE%h zKZhLtcQld;ZD+>=nqN~>GvROfueSzJD&BE*}XfU|H&(FssBqY=hPCt`d zH?@s2>I(|;fcW&YM6#V#!kUIP8$Nkdh0A(bEVj``-AAyYgwY~jB zT|I7Bf@%;7aL7Wf4dZ%VqF$eiaC38OV6oy3Z#TER2G+fOCd9Iaoy6aLYbPTN{XRPz z;U!V|vBf%H!}52L2gH_+j;`bTcQRXB+y9onc^wLm5wi3-Be}U>k_u>2Eg$=k!(l@I zcCg+flakT2Nej3i0yn+g+}%NYb?ta;R?(g5SnwsQ49U8Wng8d|{B+lyRcEDvR3+`O{zfmrmvFrL6acVP%yG98X zo&+VBg@px@i)%o?dG(`T;n*$S5*rnyiR#=wW}}GsAcfyQpE|>a{=$Hjg=-*_K;UtD z#z-)AXwSRY?OPefw^iI+ z)AXz#PfEjlwTes|_{sB?4(O@fg0AJ^g8gP}ex9Ucf*@_^J(s_5jJV}c)s$`Myn|Kd z$6>}#q^n{4vN@+Os$m7KV+`}c%4)4pv@06af4-x5#wj!KKb%caK{A&Y#Rfs z-po?Dcb1({W=6FKIUirH&(yg=*6aLCekcKwyfK^JN5{wcA3nhO(o}SK#!CINhI`-I z1)6&n7O&ZmyFMuNwvEic#IiOAwNkR=u5it{B9n2sAJV5pNhar=j5`*N!Na;c7g!l$ z3aYBqUkqqTJ=Re-;)s!EOeij=7SQZ3Hq}ZRds%IM*PtM$wV z@;rlc*NRK7i3y5BETSKuumEN`Xu_8GP1Ri=OKQ$@I^ko8>H6)4rjiG5{VBM>B|%`&&s^)jS|-_95&yc=GqjNo{zFkw%%HHhS~e=s zD#sfS+-?*t|J!+ozP6KvtOl!R)@@-z24}`9{QaVLD^9VCSR2b`b!KC#o;Ki<+wXB6 zx3&O0LOWcg4&rv4QG0)4yb}7BFSEg~=IR5#ZRj8kg}dS7_V&^%#Do==#`u zpy6{ox?jWuR(;pg+f@mT>#HGWHAJRRDDDv~@(IDw&R>9643kK#HN`!1vBJHnC+RM&yIh8{gG2q zA%e*U3|N0XSRa~oX-3EAneep)@{h2vvd3Xvy$7og(sayr@95+e6~Xvi1tUqnIxoIH zVWo*OwYElb#uyW{Imam6f2rGbjR!Y3`#gPqkv57dB6K^wRGxc9B(t|aYDGS=m$&S!NmCtrMMaUg(c zc2qC=2Z`EEFMW-me5B)24AqF*bV5Dr-M5ig(l-WPS%CgaPzs6p_gnCIvTJ=Y<6!gT zVt@AfYCzjjsMEGi=rDQHo0yc;HqoRNnNFeWZgcm?f;cp(6CNylj36DoL(?TS7eU#+ z7&mfr#y))+CJOXQKUMZ7QIdS9@#-}7y2K1{8)cCt0~-X0O!O?Qx#E4Og+;A2SjalQ zs7r?qn0H044=sDN$SRG$arw~n=+T_DNdSrarmu)V6@|?1-ZB#hRn`uilTGPJ@fqEy zGt(f0B+^JDP&f=r{#Y_wi#AVDf-y!RIXU^0jXsFpf>=Ji*TeqSY!H~AMbJdCGLhC) zn7Rx+sXw6uYj;WRYrLd^5IZq@6JI1C^YkgnedZEYy<&4(z%Q$5yv#Boo{AH8n$a zhb4Y3PWdr269&?V%uI$xMcUrMzl=;w<_nm*qr=c3Rl@i5wWB;e-`t7D&c-mcQl7x! zZWB`UGcw=Y2=}~wzrfLx=uet<;m3~=8I~ZRuzvMQUQdr+yTV|ATf1Uuomr__nDf=X zZ3WYJtHp_ri(}SQAPjv+Y+0=fH4krOP@S&=zZ-t1jW1o@}z;xk8 z(Nz1co&El^HK^NrhVHa-_;&88vTU>_J33=%{if;BEY*J#1n59=07jrGQ#IP>@u#3A z;!q+E1Rj3ZJ+!4bq9F8PXJ@yMgZL;>&gYA0%_Kbi8?S=XGM~dnQZQ!yBSgcZhY96H zrWnU;k)qy`rX&&xlDyA%(a1Hhi5CWkmg(`Gb%m(HKi-7Z!LKGRP_B8@`7&hdDy5n= z`OIxqxiVfX@OX1p(mQu>0Ai*v_cTMiw4qRt3~NBvr9oBy0)r>w3p~V0SCm=An6@3n)>@z!|o-$HvDK z|3D2ZMJkLE5loMKl6R^ez@Zz%S$&mbeoqH5`Bb){Ei21q&VP)hWS2tjShfFtGE+$z zzCR$P#uktu+#!w)cX!lWN1XU%K-r=s{|j?)Akf@q#3b#{6cZCuJ~gCxuMXRmI$nGtnH+-h z+GEi!*X=AP<|fG`1>MBdTb?28JYc=fGvAi2I<$B(rs$;eoJCyR6_bc~p!XR@O-+sD z=eH`-ye})I5ic1eL~TDmtfJ|8`0VJ*Yr=hNCd)G1p2MMz4C3^Mj?7;!w|Ly%JqmuW zlIEW^Ft%z?*|fpXda>Jr^1noFZEwFgVV%|*XhH@acv8rdGxeEX{M$(vG{Zw+x(ei@ zmfXb22}8-?Fi`vo-YVrTH*C?a8%M=Hv9MqVH7H^J$KsD?>!SFZ;ZsvnHr_gn=7acz z#W?0eCdVhVMWN12VV^$>WlQ?f;P^{(&pYTops|btm6aj>_Uz+hqpGwB)vWp0Cf5y< zft8-je~nn?W11plq}N)4A{l8I7$!ks_x$PXW-2XaRFswX_BnF{R#6YIwMhAgd5F9X zGmwdadS6(a^fjHtXg8=l?Rc0Sm%hk6E9!5cLVloEy4eh(=FwgP`)~I^5~pBEWo+F6 zSf2ncyMurJN91#cJTy_u8Y}@%!bq1RkGC~-bV@SXRd4F{R-*V`bS+6;W5vZ(&+I<9$;-V|eNfLa5n-6% z2(}&uGRF;p92eS*sE*oR$@pexaqr*meB)VhmIg@h{uzkk$9~qh#cHhw#>O%)b@+(| z^IQgqzuj~Sk(J;swEM-3TrJAPCq9k^^^`q{IItKBRXYe}e0Tdr=Huf7da3$l4PdpwWDop%^}n;dD#K4s#DYA8SHZ z&1!riV4W4R7R#C))JH1~axJ)RYnM$$lIR%6fIVA@zV{XVyx}C+a-Dt8Y9M)^KU0+H zR4IUb2CJ{Hg>CuaXtD50jB(_Tcx=Z$^WYu2u5kubqmwp%drJ6 z?Fo40g!Qd<-l=TQxqHEOuPX0;^z7iX?Ke^a%XT<13TA^5`4Xcw6D@Ur&VT&CUe0d} z1GjOVF1^L@>O)l@?bD~$wzgf(nxX1OGD8fEV?TdJcZc2KoUe|oP1#=$$7ee|xbY)A zDZq+cuTpc(fFdj^=!;{k03C69lMQ(|>uhRfRu%+!k&YOi-3|1QKB z z?n?eq1XP>p-IM$Z^C;2L3itnbJZAip*Zo0aw2bs8@(s^~*8T9go!%dHcAz2lM;`yp zD=7&xjFV$S&5uDaiScyD?B-i1ze`+CoRtz`Wn+Zl&#s4&}MO{@N!ufrzjG$B79)Y2d3tBk&)TxUTw@QS0TEL_?njX|@vq?Uz(nBFK5Pq7*xj#u*R&i|?7+6# z+|r_n#SW&LXhtheZdah{ZVoqwyT{D>MC3nkFF#N)xLi{p7J1jXlmVeb;cP5?e(=f# zuT7fvjSbjS781v?7{)-X3*?>tq?)Yd)~|1{BDS(pqC zC}~H#WXlkUW*H5CDOo<)#x7%RY)A;ShGhI5s*#cRDA8YgqG(HeKDx+#(ZQ?386dv! zlXCO)w91~Vw4AmOcATuV653fa9R$fyK8ul%rG z-wfS zihugoZyr38Im?Zuh6@RcF~t1anQu7>#lPpb#}4cOA!EM11`%f*07RqOVkmX{p~KJ9 z^zP;K#|)$`^Rb{rnHGH{~>1(fawV0*Z#)}M`m8-?ZJV<+e}s9wE# z)l&az?w^5{)`S(%MRzxdNqrs1n*-=jS^_jqE*5XDrA0+VE`5^*p3CuM<&dZEeCjoz zR;uu_H9ZPZV|fQq`Cyw4nscrVwi!fE6ciMmX$!_hN7uF;jjKG)d2@aC4ropY)8etW=xJvni)8eHi`H$%#zn^WJ5NLc-rqk|u&&4Z6fD_m&JfSI1Bvb?b<*n&sfl0^t z=HnmRl`XrFvMKB%9}>PaA`m-fK6a0(8=qPkWS5bb4=v?XcWi&hRY?O5HdulRi4?fN zlsJ*N-0Qw+Yic@s0(2uy%F@ib;GjXt01Fmx5XbRo6+n|pP(&nodMoap^z{~q ziEeaUT@Mxe3vJSfI6?uLND(CNr=#^W<1b}jzW58bIfyWTDle$mmS(|x-0|2UlX+9k zQ^EX7Nw}?EzVoBfT(-LT|=9N@^hcn-_p&sqG z&*oVs2JSU+N4ZD`FhCAWaS;>|wH2G*Id|?pa#@>tyxX`+4HyIArWDvVrX)2WAOQff z0qyHu&-S@i^MS-+j--!pr4fPBj~_8({~e1bfcl0wI1kaoN>mJL6KUPQm5N7lB(ui1 zE-o%kq)&djzWJ}ob<-GfDlkB;F31j-VHKvQUGQ3sp`CwyGJk_i!y^sD0fqC@$9|jO zOqN!r!8-p==F@ZVP=U$qSpY(gQ0)59P1&t@y?5rvg<}E+GB}26NYPp4f2YFQrQtot5mn3wu_qprZ=>Ig-$ zbW26Ws~IgY>}^5w`vTB(G`PTZaDiGBo5o(tp)qli|NeV( z@H_=R8V39rt5J5YB2Ky?4eJJ#b`_iBe2ot~6%7mLt5t8Vwi^Jy7|jWXqa3amOIoRb zOr}WVFP--DsS`1WpN%~)t3R!arKF^Q$e12KEqU36AWwnCBICpH4XCsfnyrHr>$I$4 z!DpKX$OKLWarN7nv@!uIA+~RNO)l$$w}p(;b>mx8pwYvu;dD_unryX_NhT8*Tj>BTrTTL&!?O+%Rv;b?B??gSzdp?6Uug9{ zd@V08Z$BdI?fpoCS$)t4mg4rT8Q_I}h`0d-vYZ^|dOB*Q^S|xqTV*vIg?@fVFSmMpaw0qtTRbx} z({Pg?#{2`sc9)M5N$*N|4;^t$+QP?#mov zGVC@I*lBVrOU-%2y!7%)fAKjpEFsgQc4{amtiHb95KQEwvf<(3T<9-Zm$xIew#P22 zc2Ix|App^>v6(3L_MCU0d3W##AB0M~3D00EWoKZqsJYT(#@w$Y_H7G22M~ApVFTRHMI_3be)Lkn#0F*V8Pq zc}`Cjy$bE;FJ6H7p=0y#R>`}-m4(0F>%@P|?7fx{=R^uFdISRnZ2W_xQhD{YuR3t< z{6yxu=4~JkeA;|(J6_nv#>Nvs&FuLA&PW^he@t(UwFFE8)|a!R{`E`K`i^ZnyE4$k z;(749Ix|oi$c3QbEJ3b~D_kQsPz~fIUKym($a_7dJ?o+40*OLl^{=&oq$<#Q(yyrp z{J-FAniyAw9tPbe&IhQ|a`DqFTVQGQ&Gq3!C2==4x{6EJwiPZ8zub-iXoUtkJiG{} zPaR&}_fn8_z~(=;5lD-aPWD3z8PZS@AaUiomF!G8I}Mf>e~0g#BelA-5#`cj;O5>N Xviia!U7SGha1wx#SCgwmn*{w2TRX*I literal 0 HcmV?d00001 diff --git a/sale_financial_risk_exclude_order_type/static/description/index.html b/sale_financial_risk_exclude_order_type/static/description/index.html new file mode 100644 index 000000000..e3b450e1c --- /dev/null +++ b/sale_financial_risk_exclude_order_type/static/description/index.html @@ -0,0 +1,485 @@ + + + + + +Sale Financial Risk Exclude Order Type + + + +
+

Sale Financial Risk Exclude Order Type

+ + +

Alpha License: AGPL-3 OCA/credit-control Translate me on Weblate Try me on Runboat

+

This module extends sale.order.type to integrate with +sale_financial_risk.

+

It adds two independent behaviors to sale order types:

+
    +
  • Exclude orders from financial risk computation
    • +
  • Allow confirmation bypass for financial risk blocking
    • +
+

This allows implementing flexible commercial workflows while keeping the +standard financial risk framework intact.

+
+

Features

+
    +
  • Extend sale.order.type with financial risk options
    • +
  • Exclude selected order types from risk exposure computation
    • +
  • Allow selected order types to bypass financial risk blocking
    • +
  • Keep computation and blocking behaviors independent
    • +
  • Compatible with sale_financial_risk
    • +
  • Compatible with multi-company environments
    • +
+
+
+

Design Notes

+

This module intentionally keeps the financial risk behavior directly +attached to sale.order.type.

+

The implementation avoids introducing additional rule or configuration +models in order to:

+
    +
  • keep the behavior simple
    • +
  • reduce maintenance complexity
    • +
  • align with the functional nature of sale order types
    • +
  • avoid unnecessary configuration layers
    • +
+

The module still preserves separation between:

+
    +
  • financial exposure computation
    • +
  • confirmation blocking behavior
    • +
+
+

Important

+

This is an alpha version, the data model and design can change at any time without warning. +Only for development or testing purpose, do not use in production. +More details on development status

+
+

Table of contents

+
+
+

Usage

+
+
+

Usage

+
    +
  • Exclude from Risk Computation
    • +
+

Sale orders using this type will not contribute to the partner financial +exposure calculation.

+
    +
  • Allow Risk Blocking Bypass
    • +
+

Sale orders using this type can be confirmed even when financial risk +blocking would normally prevent confirmation.

+

Both options are independent and can be combined freely.

+
+
+

Known issues / Roadmap

+
+
+

Known issues / Roadmap

+
    +
  • Add optional risk warning indicators on sale orders
    • +
  • Improve reporting of excluded order types
    • +
+
+
+

Bug Tracker

+

Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +feedback.

+

Do not contact contributors directly about support or help with technical issues.

+
+
+

Credits

+
+

Authors

+
    +
  • Binhex Systems Solutions S.L
    • +
+
+
+

Contributors

+ +
+
+

Maintainers

+

This module is maintained by the OCA.

+ +Odoo Community Association + +

OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

+

This module is part of the OCA/credit-control project on GitHub.

+

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

+
+
+
+ + diff --git a/sale_financial_risk_exclude_order_type/tests/__init__.py b/sale_financial_risk_exclude_order_type/tests/__init__.py new file mode 100644 index 000000000..a7e549f2a --- /dev/null +++ b/sale_financial_risk_exclude_order_type/tests/__init__.py @@ -0,0 +1 @@ +from . import test_sale_financial_risk_exclude_order_type diff --git a/sale_financial_risk_exclude_order_type/tests/test_sale_financial_risk_exclude_order_type.py b/sale_financial_risk_exclude_order_type/tests/test_sale_financial_risk_exclude_order_type.py new file mode 100644 index 000000000..ded8679df --- /dev/null +++ b/sale_financial_risk_exclude_order_type/tests/test_sale_financial_risk_exclude_order_type.py @@ -0,0 +1,264 @@ +from odoo.addons.base.tests.common import BaseCommon + + +class TestSaleFinancialRiskExcludeOrderType(BaseCommon): + """ + Test suite for sale_financial_risk_exclude_order_type. + Covers: + - Blocking bypass behavior + - Risk computation exclusion + - Separation between blocking and computation + - Domain integrity + - Multi-company behavior + - Sale order types without flags + """ + + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.company = cls.env.company + # --------------------------------------------------------- + # Partner + # --------------------------------------------------------- + cls.risk_partner = cls.env["res.partner"].create( + { + "name": "Risk Customer", + "customer_rank": 1, + "credit_limit": 500.0, + "risk_sale_order_include": True, + } + ) + # --------------------------------------------------------- + # Sale Order Types + # --------------------------------------------------------- + cls.type_excluded = cls.env["sale.order.type"].create( + { + "name": "Excluded Type", + "exclude_from_risk": True, + "allow_blocking_bypass": True, + } + ) + cls.type_bypass_only = cls.env["sale.order.type"].create( + { + "name": "Bypass Only", + "exclude_from_risk": False, + "allow_blocking_bypass": True, + } + ) + cls.type_normal = cls.env["sale.order.type"].create( + { + "name": "Normal Type", + "exclude_from_risk": False, + "allow_blocking_bypass": False, + } + ) + + # --------------------------------------------------------- + # Helpers + # --------------------------------------------------------- + def _create_sale_order(self, order_type=False): + """ + Create a sale order using the provided sale order type. + """ + vals = { + "partner_id": self.risk_partner.id, + "partner_invoice_id": self.risk_partner.id, + "partner_shipping_id": self.risk_partner.id, + } + if order_type: + vals["type_id"] = order_type.id + return self.env["sale.order"].create(vals) + + # --------------------------------------------------------- + # Blocking behavior + # --------------------------------------------------------- + def test_bypass_enabled(self): + """ + Order types configured with allow_blocking_bypass + must bypass financial risk blocking. + """ + order = self._create_sale_order(self.type_excluded) + self.assertTrue(order._allow_financial_risk_blocking_bypass()) + self.assertFalse(order.evaluate_risk_message(self.risk_partner)) + + def test_bypass_only_type(self): + """ + Order types configured only with blocking bypass: + - must bypass blocking + - must still contribute to risk computation + """ + order = self._create_sale_order(self.type_bypass_only) + self.assertTrue(order._allow_financial_risk_blocking_bypass()) + self.assertFalse(order.evaluate_risk_message(self.risk_partner)) + + def test_no_bypass_for_normal_type(self): + """ + Order types without bypass configuration + must preserve standard behavior. + """ + order = self._create_sale_order(self.type_normal) + self.assertFalse(order._allow_financial_risk_blocking_bypass()) + + def test_no_bypass_without_order_type(self): + """ + Orders without type_id must not bypass risk blocking. + """ + order = self._create_sale_order() + self.assertFalse(order._allow_financial_risk_blocking_bypass()) + + def test_bypass_disabled(self): + """ + Order types without bypass enabled + must not bypass blocking. + """ + order_type = self.env["sale.order.type"].create( + { + "name": "No Bypass Type", + "exclude_from_risk": True, + "allow_blocking_bypass": False, + } + ) + order = self._create_sale_order(order_type) + self.assertFalse(order._allow_financial_risk_blocking_bypass()) + + # --------------------------------------------------------- + # Risk computation domain + # --------------------------------------------------------- + def test_exclude_from_risk_domain(self): + """ + Order types configured with exclude_from_risk=True + must be excluded from the risk computation domain. + """ + domain = self.risk_partner._get_risk_sale_order_domain() + self.assertIn( + ("order_id.type_id", "not in", self.type_excluded.ids), + domain, + ) + + def test_bypass_only_does_not_affect_domain(self): + """ + Blocking bypass alone must not affect + risk computation domain. + """ + domain = self.risk_partner._get_risk_sale_order_domain() + self.assertNotIn( + ("order_id.type_id", "not in", self.type_bypass_only.ids), + domain, + ) + + def test_normal_type_does_not_affect_domain(self): + """ + Neutral order types must not affect + the risk computation domain. + """ + domain = self.risk_partner._get_risk_sale_order_domain() + self.assertNotIn( + ("order_id.type_id", "not in", self.type_normal.ids), + domain, + ) + + def test_domain_integrity(self): + """ + The resulting domain must remain list-based. + """ + domain = self.risk_partner._get_risk_sale_order_domain() + self.assertIsInstance(domain, list) + + def test_exclusion_clause_present_once(self): + """ + Exclusion clause must only appear once + in the resulting domain. + """ + domain = self.risk_partner._get_risk_sale_order_domain() + clauses = [ + clause + for clause in domain + if clause + == ( + "order_id.type_id", + "not in", + self.type_excluded.ids, + ) + ] + self.assertEqual(len(clauses), 1) + + # --------------------------------------------------------- + # Separation of concerns + # --------------------------------------------------------- + def test_computation_and_blocking_are_independent(self): + """ + Blocking bypass and risk computation exclusion + must behave independently. + """ + order = self._create_sale_order(self.type_bypass_only) + # Blocking bypass enabled + self.assertFalse(order.evaluate_risk_message(self.risk_partner)) + # Still included in computation + domain = self.risk_partner._get_risk_sale_order_domain() + self.assertNotIn( + ("order_id.type_id", "not in", self.type_bypass_only.ids), + domain, + ) + + def test_type_with_no_flags(self): + """ + Order types without any enabled flags + must not affect behavior. + """ + order_type = self.env["sale.order.type"].create( + { + "name": "Neutral Type", + "exclude_from_risk": False, + "allow_blocking_bypass": False, + } + ) + order = self._create_sale_order(order_type) + self.assertFalse(order._allow_financial_risk_blocking_bypass()) + domain = self.risk_partner._get_risk_sale_order_domain() + self.assertNotIn( + ("order_id.type_id", "not in", order_type.ids), + domain, + ) + + # --------------------------------------------------------- + # Multi-company behavior + # --------------------------------------------------------- + def test_company_specific_order_types(self): + """ + Company-specific order types must remain isolated + in their respective companies. + """ + company_2 = self.env["res.company"].create( + { + "name": "Company 2", + } + ) + partner_2 = self.env["res.partner"].create( + { + "name": "Customer Company 2", + "customer_rank": 1, + "company_id": company_2.id, + } + ) + type_company_2 = self.env["sale.order.type"].create( + { + "name": "Company 2 Type", + "company_id": company_2.id, + "exclude_from_risk": True, + "allow_blocking_bypass": True, + } + ) + order = ( + self.env["sale.order"] + .with_company(company_2) + .create( + { + "partner_id": partner_2.id, + "partner_invoice_id": partner_2.id, + "partner_shipping_id": partner_2.id, + "company_id": company_2.id, + "type_id": type_company_2.id, + } + ) + ) + self.assertTrue(order._allow_financial_risk_blocking_bypass()) diff --git a/sale_financial_risk_exclude_order_type/views/sale_order_type_views.xml b/sale_financial_risk_exclude_order_type/views/sale_order_type_views.xml new file mode 100644 index 000000000..541f8e452 --- /dev/null +++ b/sale_financial_risk_exclude_order_type/views/sale_order_type_views.xml @@ -0,0 +1,21 @@ + + + + sale.order.type.form.sale.financial.risk.exclude.order.type + sale.order.type + + + + + + + + + + +