Change on the relation between Knowledge and Procedures / Manuals....

[etobella]

Recently, I found some cases where companies don't want to set the manuals, procedures and so on in odoo because they have their own system for doing it.

Even the external systems have some benefits, however, they want to handle the nonconformities, actions, reviews and so on inside Odoo. The problem is that everything in management-system is entangled with document_page. They want to have the reference there, but avoiding the complexity of handling the information there.

I have the following proposal for 18:

1. We create a new model called mgmtsystem.document in mgmtsystem with the following information:
   1. type (of document): Procedure, Manual...
   2. kind: Document.page, URL...
   3. document_page_id
   4. URL
2. We change all the logic to integrate everything this way.
3. We create the migration scripts
4. In 19, by default, the relation with document_page will be avoided and added in a new module.

The idea is to avoid new modules in 18 and leave that split for 19 in order to minimize the changes.

There are some extra benefits on this approach. For example, we will be able to change the name PRocedure to our own language. Right now, if we do that, all the procedure cannot be selected on non-conformities.

WDYT?

@max3903 @ValentinVinagre @JordiBForgeFlow

[max3903]

I suggest importing document pages with the name and the content only has the link to the external system where the information is stored and controlled.

[etobella]

@max3903 I understand your idea, but we are adding a dependancy that is not needed and can be splitted easily as I suggested. That was the reason for my idea, it is a small change, but adds extra benefits for the future.

Also, my idea allows to remove this hardcode that makes the module non usable outside of english. https://github.com/OCA/management-system/blob/18.0/mgmtsystem_nonconformity/views/mgmtsystem_nonconformity.xml#L239

[max3903]

@etobella Happy to test it once you have a pull request.

[etobella]

After checking the code, I found that mgmtsystem does not depend on document_page. We have 2 possible options:

• Create a new module that separates the logic.
  However, this could cause issues in installations if we use document_page_procedure or rely on specific modules only.
• Add the dependancy of document_page to mgmtsystem just for this version for avoiding adding an extra module.

Which one do you prefer? The first one is less agressive and prepares for the future 🤔

[ValentinVinagre]

I'm in favor of not making abrupt changes to modules in older versions.
I'd implement point 1 after what was discussed in the issue.
The idea sounds good 😄

[diggy128]

@max3903 I understand your idea, but we are adding a dependancy that is not needed and can be splitted easily as I suggested. That was the reason for my idea, it is a small change, but adds extra benefits for the future.

Also, my idea allows to remove this hardcode that makes the module non usable outside of english. https://github.com/OCA/management-system/blob/18.0/mgmtsystem_nonconformity/views/mgmtsystem_nonconformity.xml#L239

Take a look at this comment: #518 (comment)

It fixes the language issue.

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.