[MIG] account_invoice_inter_company: Migration to 17.0

Author: cuongnmtm

account_invoice_inter_company/README.rst

@@ -50,8 +50,8 @@ Configuration
 To configure this module, you need to go to the menu *Settings > General
 Settings*, go to the tab *Companies / Inter Company OCA features*
 
-You now have access to other checks *Common Product Catalog* and
-*Invoice Auto Validation*.
+You now have access to other options *Intercompany user for invoices*
+and *Invoice Auto Validation*.
 
 To customize products sharing don't hesitate to override
 \_compute_share_product() in res.company model.
@@ -106,6 +106,9 @@ Contributors
    -  Pedro M. Baeza
 
 -  Isaac Gallart <igallart@puntsistemes.es>
+-  \`Komit <https://komit-consulting.com>\`:
+
+   -  Cuong Nguyen Mtm <cuong.nmtm@komit-consulting.com>
 
 Maintainers
 -----------

account_invoice_inter_company/__manifest__.py

@@ -7,7 +7,7 @@
 {
     "name": "Inter Company Invoices",
     "summary": "Intercompany invoice rules",
-    "version": "16.0.1.0.2",
+    "version": "17.0.1.0.0",
     "category": "Accounting & Finance",
     "website": "https://github.com/OCA/multi-company",
     "author": "Odoo SA, Akretion, Odoo Community Association (OCA)",

account_invoice_inter_company/models/account_move.py

@@ -62,8 +62,6 @@ def action_post(self):
 
     def _check_intercompany_product(self, dest_company):
         self.ensure_one()
-        if dest_company.company_share_product:
-            return
         domain = dest_company._get_user_domain()
         dest_user = self.env["res.users"].search(domain, limit=1)
         for line in self.invoice_line_ids:
@@ -76,8 +74,8 @@ def _check_intercompany_product(self, dest_company):
             except AccessError as e:
                 raise UserError(
                     _(
-                        "You cannot create invoice in company '%(dest_company_name)s' with "
-                        "product '%(product_name)s' because it is not multicompany"
+                        "You cannot create invoice in company '%(dest_company_name)s' "
+                        "with product '%(product_name)s' because it is not multicompany"
                     )
                     % {
                         "dest_company_name": dest_company.name,

account_invoice_inter_company/models/res_company.py

@@ -6,17 +6,6 @@
 class ResCompany(models.Model):
     _inherit = "res.company"
 
-    company_share_product = fields.Boolean(
-        "Share product to all companies",
-        compute="_compute_share_product",
-        compute_sudo=True,
-        help="Share your product to all companies defined in your instance.\n"
-        " * Checked : Product are visible for every company, "
-        "even if a company is defined on the partner.\n"
-        " * Unchecked : Each company can see only its product "
-        "(product where company is defined). Product not related to a "
-        "company are visible for all companies.",
-    )
     invoice_auto_validation = fields.Boolean(
         help="When an invoice is created by a multi company rule "
         "for this company, it will automatically validate it",
@@ -29,11 +18,6 @@ class ResCompany(models.Model):
         "intercompany rules.",
     )
 
-    def _compute_share_product(self):
-        product_rule = self.env.ref("product.product_comp_rule")
-        for company in self:
-            company.company_share_product = not bool(product_rule.active)
-
     def _get_user_domain(self):
         self.ensure_one()
         group_account_invoice = self.env.ref("account.group_account_invoice")

account_invoice_inter_company/models/res_config_settings.py

@@ -1,6 +1,6 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-from odoo import api, fields, models
+from odoo import fields, models
 
 
 class ResConfigSettings(models.TransientModel):
@@ -20,27 +20,3 @@ class ResConfigSettings(models.TransientModel):
         "intercompany rules. If not set the user initiating the"
         "transaction will be used",
     )
-    company_share_product = fields.Boolean(
-        "Share product to all companies",
-        help="Share your product to all companies defined in your instance.\n"
-        " * Checked : Product are visible for every company, "
-        "even if a company is defined on the partner.\n"
-        " * Unchecked : Each company can see only its product "
-        "(product where company is defined). Product not related to a "
-        "company are visible for all companies.",
-    )
-
-    @api.model
-    def get_values(self):
-        res = super().get_values()
-        product_rule = self.env.ref("product.product_comp_rule")
-        res.update(
-            company_share_product=not bool(product_rule.active),
-        )
-        return res
-
-    def set_values(self):
-        res = super().set_values()
-        product_rule = self.env.ref("product.product_comp_rule")
-        product_rule.write({"active": not bool(self.company_share_product)})
-        return res

account_invoice_inter_company/readme/CONFIGURE.md

@@ -2,7 +2,7 @@ To configure this module, you need to go to the menu *Settings \>
 General Settings*, go to the tab *Companies / Inter Company OCA
 features*
 
-You now have access to other checks *Common Product Catalog* and
+You now have access to other options *Intercompany user for invoices* and
 *Invoice Auto Validation*.
 
 To customize products sharing don't hesitate to override

account_invoice_inter_company/readme/CONTRIBUTORS.md

@@ -11,3 +11,5 @@
   - David Vidal
   - Pedro M. Baeza
 - Isaac Gallart \<<igallart@puntsistemes.es>\>
+- \`Komit \<<https://komit-consulting.com>\>\`:
+  - Cuong Nguyen Mtm \<<cuong.nmtm@komit-consulting.com>\>

account_invoice_inter_company/static/description/index.html

@@ -1,4 +1,3 @@
-<?xml version="1.0" encoding="utf-8"?>
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
@@ -9,10 +8,11 @@
 
 /*
 :Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
+:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
+Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -275,7 +275,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: grey; } /* line numbers */
+pre.code .ln { color: gray; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -301,7 +301,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic {
+span.problematic, pre.problematic {
   color: red }
 
 span.section-subtitle {
@@ -397,8 +397,8 @@ <h1 class="title">Inter Company Invoices</h1>
 <h1><a class="toc-backref" href="#toc-entry-1">Configuration</a></h1>
 <p>To configure this module, you need to go to the menu <em>Settings &gt; General
 Settings</em>, go to the tab <em>Companies / Inter Company OCA features</em></p>
-<p>You now have access to other checks <em>Common Product Catalog</em> and
-<em>Invoice Auto Validation</em>.</p>
+<p>You now have access to other options <em>Intercompany user for invoices</em>
+and <em>Invoice Auto Validation</em>.</p>
 <p>To customize products sharing don’t hesitate to override
 _compute_share_product() in res.company model.</p>
 </div>
@@ -453,12 +453,18 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 </ul>
 </li>
 <li>Isaac Gallart &lt;<a class="reference external" href="mailto:igallart&#64;puntsistemes.es">igallart&#64;puntsistemes.es</a>&gt;</li>
+<li>`Komit &lt;<a class="reference external" href="https://komit-consulting.com">https://komit-consulting.com</a>&gt;`:<ul>
+<li>Cuong Nguyen Mtm &lt;<a class="reference external" href="mailto:cuong.nmtm&#64;komit-consulting.com">cuong.nmtm&#64;komit-consulting.com</a>&gt;</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
 <h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
+<a class="reference external image-reference" href="https://odoo-community.org">
+<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
+</a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>