Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][16.0] payroll_account: Journal MISC Cannot have Default Account & Access Issue #168

Open
hussain opened this issue Sep 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@hussain
Copy link

hussain commented Sep 17, 2024

Describe the bug

In Payroll when a payslip is confirmed with rules linked to debit/credit accounts, confirming failed since there is no journal.default_account_id set in Journal. All journal of type miscellaneous will not allow selection of that account.
The question is why action_payslip_done().

To Reproduce

Affected versions: 15.0 , 16.0 (might be earlier as well)

Steps to reproduce the behavior:

  1. Ensure you have an employee with running contract.
  2. Ensure salary structure have rules, and some rules are linked to debit/credit accounts
  3. Create a payslip of employee and compute, then confirm.
    4.Popup error will show
    image

Case is tested in runbot in Payslip SLIP/001

Also if that account is set using server action, user cannot confirm since payslip will post journal entry. This call action_payslip_done should use sudo() ?

Expected behavior
Payslip should be confirmed successfully.
Error should be based on existing differences (if exist) and not to have an adjustment line in the journal entry, unless there is an analogy behind that.

@hussain hussain added the bug Something isn't working label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant