only show 'Other' section if there are uncategorized portal groups

Author: goreki

base_portal_type/models/res_groups.py

@@ -53,10 +53,10 @@ def _update_user_groups_view(self):
         )
 
         arch_root = arch.xpath("//field[@name='groups_id']")[0]
-        if arch_root:
+        if len(arch_root) and portal_groups:
             # as the original construction of the groups view makes all xml-groups
             # per application invisible, it is 'easier' to create another section for
-            # portal users and append those at the bottom of the view
+            # portal users and append the whole section at the bottom of the view
             portal_group_elem = etree.SubElement(
                 arch_root,
                 "group",
@@ -70,14 +70,17 @@ def _update_user_groups_view(self):
             for app_id, app_name in portal_groups.mapped("category_id").name_get() + [
                 (False, "Other")
             ]:
+                portal_groups_in_app = portal_groups.filtered(
+                    lambda r: (r.category_id.id or False) == app_id
+                )
+                if not portal_groups_in_app:
+                    continue
                 app_group_elem = etree.SubElement(
                     portal_group_elem,
                     "group",
                     string=app_name,
                 )
-                for group in portal_groups.filtered(
-                    lambda r: (r.category_id.id or False) == app_id
-                ):
+                for group in portal_groups_in_app:
                     field_name = name_boolean_group(group.id)
                     for field_node in arch.xpath("//field[@name='%s']" % field_name):
                         field_node.attrib["attrs"] = non_public_attrs