[data-1831-1832] Update flows documentation #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update url * Remove volumes * Update build command
alicia-koh
requested review from
csafreen,
SantanM,
satish-a0,
suwarnoong and
p-hoffmann
as code owners
KangJingA
approved these changes
Apr 9, 2025
csafreen
reviewed
Apr 9, 2025
csafreen
reviewed
Apr 9, 2025
csafreen
reviewed
Apr 9, 2025
csafreen
reviewed
Apr 9, 2025
csafreen
reviewed
Apr 9, 2025
csafreen
reviewed
Apr 9, 2025
csafreen
reviewed
Apr 9, 2025
csafreen
reviewed
Apr 9, 2025
csafreen
reviewed
Apr 9, 2025
Zhimin-arya
reviewed
Apr 9, 2025
docker-compose-local.yml
Outdated
| @@ -10,6 +10,7 @@ services: | |||
| - ./ui/package.json:/usr/src/plugins/d2e-ui/package.json # For local ui development only | |||
| # - ./ui/resources:/usr/src/local-resources # For local ui development only | |||
| # - ../trex/core:/usr/src/core # For debugging trex with local code | |||
| # - ./flows/base:/usr/src/plugins/d2e-flows/base # For local flow development only | |||
There was a problem hiding this comment.
Should the flow use d2e-flows as root folder?
# - ./flows/base:/usr/src/plugins/d2e-flows # For local flow development only
There was a problem hiding this comment.
After testing, only 1 package.json has to be in d2e flows, so I have updated the example.
csafreen
reviewed
Apr 9, 2025
csafreen
approved these changes
Apr 11, 2025
Zhimin-arya
approved these changes
Apr 11, 2025
suwarnoong
approved these changes
Apr 29, 2025
csafreen
pushed a commit
that referenced
this pull request
Apr 30, 2025
* Update flows README * Add scripts to generate package json, openapi spec * Add static files * Update dc local example mount for flows * Update flows * Regenerate package.json for all flows * Switch images to ohdsi org * Update white rabbit package.json * Change image prefix
csafreen
pushed a commit
that referenced
this pull request
Apr 30, 2025
* Update flows README * Add scripts to generate package json, openapi spec * Add static files * Update dc local example mount for flows * Update flows * Regenerate package.json for all flows * Switch images to ohdsi org * Update white rabbit package.json * Change image prefix
amit-sharma-d4l
pushed a commit
that referenced
this pull request
May 2, 2025
* Update flows README * Add scripts to generate package json, openapi spec * Add static files * Update dc local example mount for flows * Update flows * Regenerate package.json for all flows * Switch images to ohdsi org * Update white rabbit package.json * Change image prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)