-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle fractional SEG objects #1346
Comments
Yeah this one is interesting, this would be the best thing to do, but it'd essentially be a different data type in Is it common to have multiple fractional segments in one DICOM SEG on one referenced series? |
Not sure if there's any consensus on this, but if it's okay according to the standard then probably somebody will do it. It would be great if we could work on promoting best practices for how people should structure their SEG instances. (Comments @fedorov ?) |
I'm sure its DICOM compliant, but the web dev in me is already screaming internally about the potential consequences on resource allocation :). |
From a quick look, I am not sure how this is related to #1345 - can you clarify? Also, considering we don't have any fractional SEGs in TCGA, and it's not in IDC MVP, I don't consider this to be IDC priority. I have very limited experience with fractional SEG, I don't think I have seen any examples other than the objects produced by BrainLab, and I don't know of any tools that create fractional SEGs. |
We confirmed with @pieper that the segmentations in that kidney collections are binary, so the question is why that fractional error is coming up. |
It turns out we do have fractional segmentations in IDC, which I think turns this supporting fractional segmentations into a priority. @Punzo how difficult is this going to be to implement? Example dataset from IDC: https://viewer.imaging.datacommons.cancer.gov/viewer/1.3.6.1.4.1.14519.5.2.1.7695.4164.330974290504454152904316943429 |
@fedorov supporting fractional segmentations is rather complicated and it would involve various steps:
|
I believe handling fractional segmentation is going to be much easier in OHIF v3 (modulo resource issues). Maybe for v2 we could just binarize the segmentations (with a user warning). |
This might make sense. It might be that all fractional segs are actually binary, but saved as fractional. We should to check. |
Ok I will check the actual values in the array. In case, should I use a simple thresholding for binarizing them? I fear anything more convoluted can be slow in JavaScript. |
yes, just thresholding should be fine. Probably just zero/non-zero but let us know if that doesn't look right for the data values. |
PR with summary of my findings is here: dcmjs-org/dcmjs#309 @pieper @fedorov |
I would really appreciate OHIF's support for fractional segmentations. I have heatmaps formatted as DICOM-SEG. @fedorov There are tools to create fractional SEGs: https://github.com/razorx89/pydicom-seg/tree/feature/write-fractional |
@georg-walther the issue is that (from my perspective, as IDC https://portal.imaging.datacommons.cancer.gov/ lead), we do not have any fractional SEG series in IDC, while at the same time we have a lot of other issues in OHIF that are in the critical path for IDC, so I cannot prioritize working on this issue. Can you at least share a sample fractional SEG and the accompanying image series, and attach to this issue, so this can be worked on in the future? |
Request
Related to #1345, the segmentation is encoded as fractional but we currently don't load it.
Instead we throw this as an error:
What feature or change would you like to see made?
We should probably just threshold this to binary for now. Better of course would be to handle the fractional case as a kind of heatmap overlay.
Why should we prioritize this feature?
It's part of the DICOM standard and we have examples of data encoded this way.
The text was updated successfully, but these errors were encountered: