Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAPS-Deps] update Checker Ver #1312

Merged
merged 5 commits into from
Feb 12, 2025
Merged

[DAPS-Deps] update Checker Ver #1312

merged 5 commits into from
Feb 12, 2025

Conversation

AronPerez
Copy link
Collaborator

@AronPerez AronPerez commented Feb 11, 2025 •
edited by sourcery-ai bot
Loading

PR Description

JoshuaSBrown/cpp-py-formatter/[email protected]
-> JoshuaSBrown/cpp-py-formatter/[email protected]

Tasks

  • - A description of the PR has been provided, and a diagram included if it is a new feature.
  • - Formatter has been run
  • - CHANGELOG comment has been added
  • - Labels have been assigned to the pr
  • - A reviwer has been added
  • - A user has been assigned to work on the pr
  • - If new feature a unit test has been added

Summary by Sourcery

CI:

  • Update the version of cpp-py-formatter/check used in the format-check workflow to 0.3.0.

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Feb 11, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request updates the version of the cpp-py-formatter dependency in the GitHub Actions workflow used for code formatting. The change improves the code formatting check by leveraging newer features and fixes available in version 0.3.0.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Dependency version update in the GitHub Actions workflow
  • Updated the cpp-py-formatter/check action version from v0.2.3 to 0.3.0
  • Modified the YAML configuration in the workflow to ensure the formatting check uses the latest version
 .github/workflows/format-check.yml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Feb 11, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AronPerez - I've reviewed your changes - here's some feedback:

Overall Comments:

  • This looks like a straightforward dependency update - thanks for keeping things up to date!
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@AronPerez AronPerez linked an issue Feb 12, 2025 that may be closed by this pull request
[CI, Tag] Address Tag Formatter Breakage #1314
Open
1 task
@JoshuaSBrown JoshuaSBrown changed the base branch from devel to release_February_2025 February 12, 2025 19:18
@JoshuaSBrown JoshuaSBrown merged commit d9f1626 into release_February_2025 Feb 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI, Tag] Address Tag Formatter Breakage
2 participants
@AronPerez @JoshuaSBrown