Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting #34

Open
alexander-novo opened this issue Dec 3, 2024 · 0 comments · May be fixed by #39
Open

Add linting #34

alexander-novo opened this issue Dec 3, 2024 · 0 comments · May be fixed by #39
Assignees
Labels
development Features/Tools related to development of GridKit, rather than use as a library. enhancement New feature or request

Comments

@alexander-novo
Copy link
Collaborator

There are a few style guidelines (#5) that can't be enforced by formatting alone, since they're outside the purview of formatting. For example: identifier naming schemes and error handling. These can be checked by a linter, though, and linting in general isn't a bad idea in a C++ codebase. If we're requiring clang-format as a dev dependency, then we can use clang-tidy, which is also included in clang. This can be added to precommit hooks (#33) and CI (#25).

@alexander-novo alexander-novo added development Features/Tools related to development of GridKit, rather than use as a library. enhancement New feature or request labels Dec 3, 2024
@alexander-novo alexander-novo linked a pull request Jan 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Features/Tools related to development of GridKit, rather than use as a library. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants