Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Fix inconsistent 0 or 1 based indexing #70

Open
shakedregev opened this issue Mar 11, 2025 · 0 comments
Open

Enhancement: Fix inconsistent 0 or 1 based indexing #70

shakedregev opened this issue Mar 11, 2025 · 0 comments
Assignees
@abirchfield @shakedregev

Comments

@shakedregev
Copy link
Collaborator

For example TransmissionLine.cpp has 1 based indexing for voltages, whereas LinearTransformer.cpp has 0 based indexing for inductances.

Suggested fix: Decide which one makes sense to apply broadly, or come up with some rule for when to use 0/1 indexing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abirchfield abirchfield

@shakedregev shakedregev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abirchfield @shakedregev