Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gram-Schmidt method allocated incorrectly in LinSolverIterativeRandFGMRES class #235

Open
pelesh opened this issue Feb 18, 2025 · 0 comments · May be fixed by #225
Open

Gram-Schmidt method allocated incorrectly in LinSolverIterativeRandFGMRES class #235

pelesh opened this issue Feb 18, 2025 · 0 comments · May be fixed by #225
Assignees
Labels
bug Something isn't working

Comments

@pelesh
Copy link
Collaborator

pelesh commented Feb 18, 2025

In the LinSolverIterativeRandFGMRES:setup method, Gram-Schmidt orthogonalization is allocated as

    GS_->setup(n_, restart_);

This is incorrect, and may cause runtime errors and possibly segfault. Instead of the size of the linear system n_, the Gram-Schmidt class needs to be allocated with respect to the size of the sketching subspace:

    GS_->setup(k_rand_, restart_);

CC @kswirydo @shakedregev

@pelesh pelesh added the bug Something isn't working label Feb 18, 2025
@pelesh pelesh added this to the Release 0.99.2 milestone Feb 18, 2025
@pelesh pelesh self-assigned this Feb 18, 2025
@pelesh pelesh linked a pull request Mar 11, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant