-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace links in custom footer by MkDocs navigation #5314
Comments
My current take on this:
|
Any opinions on dropping the bottom menu? You can get the full documentation for yourself by downloading an asset generated from the Documentation workflow in Actions tab or browsing commits on main. The artifacts expire but a latest one currently is: https://github.com/OSGeo/grass/actions/runs/13842127864/artifacts/2747987237 |
I would drop it, it doesn't really fit with the new layout and it links to pages with old layout so the contrast is impressive Does dropping this bottom menu mean we also drop the topic and keyword listing? Maybe this was discussed elsewhere, I just was not able to keep up with the huge amount of issues and PRs on docs (which is amazing! 💯 not complaining!) |
If you are already planning to house the Full Index elsewhere, I would drop the footer altogether and keep all of the indexes together with the Full Index (or perhaps as subsections of the Full Index if the hierarchy permits). It sounds like the development issues caused by the current state are not worth the benefit they provide to users by being ever-present. [Just my opinion as I'm slowly jumping in here.] |
I agree. I also think that the navigation is done in a different way now.
Indeed it is, but going online to the old layout is an unrelated issue. When the new doc would be online for stable version, it would go to the new layouts. However, the fact that it links to online version is a bug introduced while countering another bug which speaks to the complexity this introduces (complexity in the sense that this is thing which MkDocs is not build to handle at this point).
There is no other discussion besides the bullet points above. We can use tags instead of keywords while still calling them keywords and keep the the URLs. We can also keep generating topic pages. There is probably no need to list keywords for each tool again and just link to topic in one case like the custom listing does. This is worth another issue.
Good! :-) We trying to have issues in addition to PRs and we have a project, checklists, sub issues, all that trying to facilitate reviews or diving into it in general. However, it is a lot and we discovered many things only along the way. It is a lot of work, much more than expected, and without the tracking, I would have hard time figuring out the status myself. |
The
The full index here is a list of all tools. So the naming is little misleading, it is not index of all pages, only of all tool pages.
And we actually get the always-present link with the top menu for the full index page.
Thanks! |
This is removing the series of links in the footer of the new documentation which go to the various index pages. These links to index pages served as a menu in the custom HTML documentation, but don't have much use in the new documentation which is using MkDocs navigation with a top bar menu being the main navigation place. In very special cases, the bottom bar contained extra link to GUI and the link to tool category would be generated dynamically. This has a limited use as menus are not expected to be changing, instead you expect to find things in the same place there. (So this is something which the new MkDocs menus don't have, but it is not a problem.) In the future, if anything from this footer links should be linked from menu, it should be added to the new menu. The full index having links to all tools is part of the menu. Closes OSGeo#5314
See PR #5427 which removes the footer. |
Replace the custom footer links to index pages by MkDocs nav (menu) items. This can be at the top or the bottom and it does not have to the exact links or wording, the point is to have whatever is the best, not necessarily the original.
The current footer has an issue that the links either don't work for addons which are in a subdir or they need to be absolute URLs, so they would link to a wrong version and always online. This is due to an MkDocs limitation ("it's not possible to use relative links at this point"). Rather than overcoming the issue, our time is probably better spent on creating a better navigation rather than maintaining a block of links which were replacing a missing navigation in the custom HTML doc.
This may actually remove the need to have the large partial footer file which does not seem to be something we want to maintain - there is a ton of general code which we don't customize and the only reason we customize it are the footer links:
Current state
The text was updated successfully, but these errors were encountered: