-
-
Notifications
You must be signed in to change notification settings - Fork 418
Description
Describe the bug
I kept my OSGeo4W installation up to date, but didn't really launch GRASS on Windows for a while. The latest nightly didn't launch, and opening grass85 in the OSGeo4W Shell shows a traceback in the find_grass_python_package() function. After reverting to a previous version, then downloading multiple old nightlies from https://download.osgeo.org/osgeo4w/v2/snapshots/20250830-001051/x86_64/release/grass-dev/?C=M&O=D, then bisecting when it stopped working, (with tips from the file's history https://github.com/OSGeo/grass/commits/main/lib/init), the problem was introduced in #5933 with FHS related changes
To reproduce
- Install any grass-dev version from OSGeo4W installer on Windows.
- Launch "GRASS GIS 8.5.0dev" (the shortcut still uses GRASS GIS)
- Command appears and closes, as there's an error.
- Open the "OSGeo4W shell"
- Type
grass85and press the enter key to start grass85 - See the traceback
Expected behavior
Have grass 8.5 launch on Windows.
Screenshots
System description
- Operating System: Windows 11 24H2
- GRASS version: 8.5
- details about further software components: Not working
Additional context
I thought that #6239 might have been the cause, but no. Probably the collaborator was already hitting this problem.
See the last two screenshots. The problem is that the path replaced in the file has traces to the source or installation directory on the build server, not the installed path.
The fix might in part come from us, but probably need some changes in the OSGeo4W build scripts, where these kind of path overrides on installation are done. The current file is at https://github.com/jef-n/OSGeo4W/blob/d183e43f08609ddb6ef9d3644c89392922f3a1c0/src/grass-dev/osgeo4w/package.sh