Merge pull request #211 from OSVR/dont-always-hardware-detect

Don't always hardware detect

Author: rpavlik

inc/osvr/Server/Server.h

@@ -137,6 +137,13 @@ namespace server {
         /// @brief Load all auto-loadable plugins.
         OSVR_SERVER_EXPORT void loadAutoPlugins();
 
+        /// @brief Adds the behavior that hardware detection should take place
+        /// on client connection.
+        ///
+        /// Safe to call from any thread, even when server is running, though it
+        /// makes the most sense as a startup option.
+        OSVR_SERVER_EXPORT void setHardwareDetectOnConnection();
+
         /// @brief Instantiate the named driver with parameters.
         /// @param plugin The name of a plugin.
         /// @param driver The name of a driver registered by the plugin for

src/osvr/Server/ConfigureServer.cpp

@@ -149,8 +149,11 @@ namespace server {
             m_server = Server::create(connPtr);
         }
 
-        if (sleepTime > 0.0)
+        if (sleepTime > 0.0) {
             m_server->setSleepTime(sleepTime);
+        }
+
+        m_server->setHardwareDetectOnConnection();
 
         return m_server;
     }

src/osvr/Server/Server.cpp

@@ -66,6 +66,10 @@ namespace server {
 
     void Server::loadAutoPlugins() { m_impl->loadAutoPlugins(); }
 
+    void Server::setHardwareDetectOnConnection() {
+        m_impl->setHardwareDetectOnConnection();
+    }
+
     void Server::instantiateDriver(std::string const &plugin,
                                    std::string const &driver,
                                    std::string const &params) {

src/osvr/Server/ServerImpl.cpp

@@ -90,10 +90,9 @@ namespace server {
             &ServerImpl::m_handleUpdatedRoute, this);
 
         // Things to do when we get a new incoming connection
+        // No longer doing hardware detect unconditionally here - see triggerHardwareDetect()
         m_commonComponent =
             m_systemDevice->addComponent(common::CommonComponent::create());
-        m_commonComponent->registerPingHandler(
-            [&] { triggerHardwareDetect(); });
         m_commonComponent->registerPingHandler([&] { m_sendTree(); });
 
         // Set up the default display descriptor.
@@ -157,6 +156,11 @@ namespace server {
 
     void ServerImpl::loadAutoPlugins() { m_ctx->loadPlugins(); }
 
+    void ServerImpl::setHardwareDetectOnConnection() {
+        m_commonComponent->registerPingHandler(
+            [&] { triggerHardwareDetect(); });
+    }
+
     void ServerImpl::instantiateDriver(std::string const &plugin,
                                        std::string const &driver,
                                        std::string const &params) {

src/osvr/Server/ServerImpl.h

@@ -84,6 +84,9 @@ namespace server {
         /// @brief Load all auto-loadable plugins.
         void loadAutoPlugins();
 
+        /// @copydoc Server::setHardwareDetectOnConnection()
+        void setHardwareDetectOnConnection();
+
         /// @copydoc Server::triggerHardwareDetect()
         void triggerHardwareDetect();