Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.4 protocol cannot parse creature talk/speak #218

Open
V0RT4C opened this issue Jul 20, 2022 · 0 comments
Open

7.4 protocol cannot parse creature talk/speak #218

V0RT4C opened this issue Jul 20, 2022 · 0 comments

Comments

@V0RT4C
Copy link

V0RT4C commented Jul 20, 2022

The problem is in OTClient source file protocolcodes.cpp.
These 2 functions:

translateMessageModeFromServer
buildMessageModesMap

In function buildMessageModesMap there is no messageModeMap being built if the client protocol is < 760.
And in translateMessageModeFromServer it will always return OTC::MessageInvalid if the messagemode is not found in the MessageModeMap.

I tried changing line 189 in OTClient source:

} else if(version >= 760) {

to this:

} else if(version >= 740) {

and it works using 760 message modes at least.

Please update this so 7.4 creature speak/talk can work in OTClient v8

(Same is true for text messages by the way)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant