Research Borg Hand Analyser Sync deletes all stored points.

[Hawk-v3]

Description of issue

See title.

Difference between expected and actual behavior

Expected:
Find 10K worth of research points with a friendly Maintcrawler.
Synch points to server.
See: "You connect to the research server, push your data upstream to it, then pull the resulting merged data from the master branch."
Goto R&D Console.
See 10K points.

Actual:
Find 10K worth of research points with a friendly Maintcrawler.
Synch points to server.
See: "You connect to the research server, push your data upstream to it, then pull the resulting merged data from the master branch."
Goto R&D Console.
See fucking 0 points.

Steps to reproduce

As above.

Length of time in which bug has been known to occur

Seen 04/02/2021, Mr Fox confirmed bug is something they've seen.

Client version, Server revision & Game ID

Server revision: master - 2021-02-04
7dc2aac

Issue bingo

Please check whatever applies. More checkboxes checked increase your chances of the issue being looked at sooner.

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

[zackerycodestoo]

This is likely connected to #73 -- it may have never been tested with cyborg uploads. Points are zeroed out to fix an exploit that appears to have been in Eris code.

The line I suspect is 345 in code/modules/research/rdconsole.dm:

files.research_points = 0 //Occulus edit. Fixes exploit

[Hawk-v3]

There is no warning of this.

[Jamini]

#73 was never tested with cyborg uploads. We will need to refactor this.