Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetricCollection returns error with children #2772

Open
0xJem opened this issue Apr 24, 2023 · 2 comments · May be fixed by #2834
Open

MetricCollection returns error with children #2772

0xJem opened this issue Apr 24, 2023 · 2 comments · May be fixed by #2834
Assignees

Comments

@0xJem
Copy link
Contributor

0xJem commented Apr 24, 2023

Type '{ children: Element[]; }' has no properties in common with type 'IntrinsicAttributes'.ts(2559)

This will likely require a change in the component library.

This may be of use: https://stackoverflow.com/a/73288819

@brightiron
Copy link
Contributor

I'll double check but I think this is a false positive and type issue due to incorrect types being used. We're still using react 17, but react types may be pointing at 18 where children types changed.

@brightiron brightiron linked a pull request May 22, 2023 that will close this issue
@0xJem
Copy link
Contributor Author

0xJem commented Sep 27, 2023

@brightiron any luck with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants