Skip to content

Conversation

@fadi-george
Copy link
Collaborator

@fadi-george fadi-george commented Dec 5, 2025

Description

One Line Summary

Main package size:

react-native-onesignal-5.2.14.tgz

Total files: 188
Shasum: 5f58f37cf5224d0bbed5d634cd264f80179761f8
Integrity: sha512-UtqlgggBbW4oE[...]UxCnM6VdcOApQ==
Unpacked size: 1.39MB
Packed size: 0.36MB

Branch:

react-native-onesignal-5.2.14.tgz

Total files: 82
Shasum: e887d437e81b7de01647fc86caed2a58487947cf
Integrity: sha512-macUFd/oNlgq4[...]P7J+kSfRd9zUA==
Unpacked size: 0.56MB
Packed size: 223.0KB

Details

  • adds build thats build root, packages it up
  • updates example package script to use file:../../react-native-onesignal.tgz for installing the test package

Motivation

Want to reduce package size for distribution.

Manual testing

In example project, ran bun run android and didn't not see any errors.
Also ran bun run ios and seemed fine.

Screenshot 2025-12-05 at 3 02 01 PM Screenshot 2025-12-05 at 3 17 12 PM

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@fadi-george fadi-george requested a review from a team as a code owner December 5, 2025 22:03
@fadi-george fadi-george requested a review from nan-li December 5, 2025 22:03
@fadi-george fadi-george force-pushed the fg/add-files-prop branch 2 times, most recently from e18b068 to 429ddb1 Compare December 5, 2025 22:58
@fadi-george fadi-george changed the title ci: add files property for react-native package chore: add files property for react-native package Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants