From dec8c46448911cbc650ee085d7da1532a7d73091 Mon Sep 17 00:00:00 2001 From: Abdullah Izzuddiin Alqassam Date: Fri, 29 Nov 2019 17:21:48 +0700 Subject: [PATCH] Fix sendEvent fired before React was fully set up **Bug** The application crashed after received notification when application is still starting up (the React instance had not been fully set up) **Resolved By** Add react instance checker before emit event --- .../java/com/geektime/rnonesignalandroid/RNOneSignal.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/android/src/main/java/com/geektime/rnonesignalandroid/RNOneSignal.java b/android/src/main/java/com/geektime/rnonesignalandroid/RNOneSignal.java index aae997cd..59f3da59 100644 --- a/android/src/main/java/com/geektime/rnonesignalandroid/RNOneSignal.java +++ b/android/src/main/java/com/geektime/rnonesignalandroid/RNOneSignal.java @@ -100,6 +100,10 @@ private void initOneSignal() { } private void sendEvent(String eventName, Object params) { + if(!mReactContext.hasActiveCatalystInstance()) { + return; + } + mReactContext .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class) .emit(eventName, params);