Skip to content

Conversation

@x-sheep
Copy link
Contributor

@x-sheep x-sheep commented Nov 27, 2025

This will make sure Data is not encoded as base64 unless it's necessary for the request, i.e. it's part of the querystring or headers. A FormData request should always preserve the data as-is, to keep the same functionality as passing in a URL.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @4brunu (2019/11) @dydus0x14 (2023/06)

@4brunu
Copy link
Contributor

4brunu commented Nov 27, 2025

Hi @x-sheep, thanks for creating this PR.
Does this PR fixes this issue #21444?
Thanks

@x-sheep x-sheep marked this pull request as draft November 27, 2025 14:27
@x-sheep
Copy link
Contributor Author

x-sheep commented Nov 27, 2025

@4brunu It should fix that issue, but right now my uploads still fail because they don't have a filename or content type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants