Skip to content

Conversation

@artnan
Copy link

@artnan artnan commented Nov 28, 2025

Summary

Fixes #22457

Header parameters (in: header) are accepted as method parameters in the generated
google-api-client Java client but are never added to the HTTP request. This PR is targeting java so mentioning the Java committee here @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

Changes

Updated api.mustache to add header parameters to HttpRequest before calling execute():

  • Main ForHttpResponse method
  • InputStream variant method
  • Params map variant method

Testing

Generated a client with header parameters and verified headers are now properly sent locally.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@artnan artnan changed the title Fixes #22457 Header parameters (in: header) are accepted as method parameters in the generated google-api-client Java client but are never added to the HTTP request. [Java] Header parameters (in: header) are accepted as method parameters in the generated google-api-client Java client but are never added to the HTTP request. Nov 28, 2025
  Header parameters defined in OpenAPI specs were being accepted as method
  parameters but never actually added to the HTTP request.

  Fixes OpenAPITools#22457
@artnan artnan force-pushed the fix/google-api-client-header-params branch from 2fd4086 to 2e1ed1c Compare November 28, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [java][google-api-client] Header parameters are accepted but not added to HTTP requests

1 participant