Update doRedfishEndpointPut to create/update entry instead of just update
#45
+83
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #44 by changing the behavior of
doRedfishEndpointPutto create a newRedfishEndpointif it does not exist for the/Inventory/RedfishEndpoints/{xname}endpoint. It should also parse data withSystemsandManagersproperties similar to thedoRedfishEndpointPostfunction and createRedfishEndpoint,Components, andComponentEndpoints.To test, try sending data to the endpoint mentioned above (may need verification):
Where
data.jsonis something like the following:{ "ID": "x1000c1s7b0", "Type": "NodeBMC", "Name": "cg01", "MACAddr": "b4:2e:99:a6:63:cf", "IPAddress": "172.16.0.101", "SchemaVersion": 1, "Systems": [ { "uri": "https://cable-guys.si.usrc/redfish/v1/Systems/x1000c1s7b0n0", "name": "cg01", "ethernet_interfaces": [ { "mac": "b4:2e:99:a6:06:47", "ip": "172.16.0.1", "name": "x1000c1s7b0n0", "description": "Interface 0 for cg01" } ] } ], "Managers": [ { "uri": "https://cable-guys.si.usrc/redfish/v1/Managers/x1000c1s7b0", "name": "x1000c1s7b0", "ethernet_interfaces": [ { "mac": "b4:2e:99:a6:63:cf", "ip": "172.16.0.101", "name": "x1000c1s7b0", "description": "Interface for BMC x1000c1s7b0" } ], "type": "NodeBMC" } ] }Some other things to consider before merging:
xnameprovided in the URL or in the request body (it's usually specified in the body like seen above)?