Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config.hpp out of include folder #419

Open
thirtytwobits opened this issue Jan 29, 2025 · 2 comments
Open

Move config.hpp out of include folder #419

thirtytwobits opened this issue Jan 29, 2025 · 2 comments

Comments

@thirtytwobits
Copy link
Contributor

When pulling libcyphal in as a submodule or cmake external project it's very difficult to exclude the default config.hpp from include paths to allow it to be overridden by the application. We should provide the default in a different folder and allow the application to either use it by including that path or to create their own.

See https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/main/examples/template_configuration/readme.md for an example of a project that does this.

@thirtytwobits
Copy link
Contributor Author

We should also, always include this header as libcyphal/config.hpp or we'll want to rename it to libcyphal_config.hpp

@emrainey
Copy link

Definitely need a way to exclude the default config and have your own. Separate directories make it easy to select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants