Skip to content

eliminate use of .env file #1569

@huss

Description

@huss

Is your feature request related to a problem? Please describe.

OED currently allows the use of a .env file and values set in the docker-compose.yml file. I think the idea may have been to allow easy override of the values via the .env. However, one can get a similar result by using a second docker config file to replace with the desired new values without changing the main docker config file. Also, having two locations of sensitive information seems less desirable and may make it harder when OED transitions to secure storage of these values.

Describe the solution you'd like

The proposal is the eliminate the .env file/usage and only use the docker-compose.yml file.

Describe alternatives you've considered

Leave as is.

Additional context

This is going to require finding and updating every place in OED that uses the .env file. Note this is likely separate from the env values from docker. I quickly looked at where env is done and found these files to consider (probably not a complete list):

  • src/scripts/changePostgresPass.js (in PR Fix Insecure Default Configuration #1554 and likely merged soon)
  • src/scripts/installOED.sh
  • src/server/config.js
  • src/server/test/common.js (unclear if using .env)
  • .github/workflows/build.yml (seem okay but listed)
  • client.js (unclear if using .env)

Metadata

Metadata

Assignees

No one assigned

    Labels

    p-medium-priorityreservedExpected to be assigned to developer by project so others should not work on without prior approval.t-enhancementThis issues tracks a potential improvement to the software

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions