Missing hidden tax

dvdsndr · colinmollenhour · commit 1e29f23a51a9 · 2018-03-09T14:06:05.000-05:00
will cause paypal to generate fraud error
diff --git a/app/code/core/Mage/Paypal/Model/Hostedpro/Request.php b/app/code/core/Mage/Paypal/Model/Hostedpro/Request.php
@@ -157,7 +157,7 @@ protected function _getOrderData(Mage_Sales_Model_Order $order)
     {
         $request = array(
             'subtotal'      => $this->_formatPrice($order->getBaseSubtotal()),
-            'tax'           => $this->_formatPrice($order->getBaseTaxAmount()),
+            'tax'           => $this->_formatPrice($order->getBaseTaxAmount() + $order->getHiddenTaxAmount() ),
             'shipping'      => $this->_formatPrice($order->getBaseShippingAmount()),
             'invoice'       => $order->getIncrementId(),
             'address_override' => 'true',

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ protected function _getOrderData(Mage_Sales_Model_Order $order)`
`157`	`157`	`{`
`158`	`158`	`$request = array(`
`159`	`159`	`'subtotal' => $this->_formatPrice($order->getBaseSubtotal()),`
`160`		`- 'tax' => $this->_formatPrice($order->getBaseTaxAmount()),`
	`160`	`+ 'tax' => $this->_formatPrice($order->getBaseTaxAmount() + $order->getHiddenTaxAmount() ),`
`161`	`161`	`'shipping' => $this->_formatPrice($order->getBaseShippingAmount()),`
`162`	`162`	`'invoice' => $order->getIncrementId(),`
`163`	`163`	`'address_override' => 'true',`