rector: SymplifyQuoteEscapeRector (#5043)

- https://getrector.com/rule-detail/symplify-quote-escape-rector

Author: sreichel

.rector.php

@@ -79,7 +79,6 @@
             CodingStyle\FuncCall\StrictArraySearchRector::class, # todo: TMP
             CodingStyle\If_\NullableCompareToNullRector::class, # todo: TMP
             CodingStyle\PostInc\PostIncDecToPreIncDecRector::class, # todo: TMP
-            CodingStyle\String_\SymplifyQuoteEscapeRector::class, # todo: TMP
             DeadCode\Assign\RemoveUnusedVariableAssignRector::class, # todo: TMP
             DeadCode\Cast\RecastingRemovalRector::class, # todo: TMP  (!?!)
             DeadCode\ClassMethod\RemoveUnusedConstructorParamRector::class, # todo: TMP (!?!)

app/code/core/Mage/Adminhtml/Block/Api/Buttons.php

@@ -25,7 +25,7 @@ protected function _prepareLayout()
             $this->getLayout()->createBlock('adminhtml/widget_button')
                 ->setData([
                     'label'     => Mage::helper('adminhtml')->__('Back'),
-                    'onclick'   => 'window.location.href=\'' . $this->getUrl('*/*/') . '\'',
+                    'onclick'   => "window.location.href='" . $this->getUrl('*/*/') . "'",
                     'class' => 'back',
                 ]),
         );
@@ -55,9 +55,9 @@ protected function _prepareLayout()
             $this->getLayout()->createBlock('adminhtml/widget_button')
                 ->setData([
                     'label'     => Mage::helper('adminhtml')->__('Delete Role'),
-                    'onclick'   => 'if(confirm(\'' . Mage::helper('core')->jsQuoteEscape(
+                    'onclick'   => "if(confirm('" . Mage::helper('core')->jsQuoteEscape(
                         Mage::helper('adminhtml')->__('Are you sure you want to do this?'),
-                    ) . '\')) roleForm.submit(\'' . $this->getUrl('*/*/delete') . '\'); return false;',
+                    ) . "')) roleForm.submit('" . $this->getUrl('*/*/delete') . "'); return false;",
                     'class' => 'delete',
                 ]),
         );

app/code/core/Mage/Adminhtml/Block/Api/User/Edit.php

@@ -23,9 +23,9 @@ public function __construct()
 
         $this->_updateButton('save', 'label', Mage::helper('adminhtml')->__('Save User'));
         $this->_updateButton('delete', 'label', Mage::helper('adminhtml')->__('Delete User'));
-        $this->_updateButton('delete', 'onclick', 'if(confirm(\'' . Mage::helper('core')->jsQuoteEscape(
+        $this->_updateButton('delete', 'onclick', "if(confirm('" . Mage::helper('core')->jsQuoteEscape(
             Mage::helper('adminhtml')->__('Are you sure you want to do this?'),
-        ) . '\')) editForm.submit(\'' . $this->getUrl('*/*/delete') . '\'); return false;');
+        ) . "')) editForm.submit('" . $this->getUrl('*/*/delete') . "'); return false;");
     }
 
     /**

app/code/core/Mage/Adminhtml/Block/Catalog/Category/Helper/Pricestep.php

@@ -57,6 +57,6 @@ public function getElementHtml()
             . Mage::helper('adminhtml')->__('Use Config Settings') . '</label>';
 
         return $html . ('<script type="text/javascript">toggleValueElements($(\'' . $htmlId . '\'), $(\'' . $htmlId
-            . '\').parentNode);' . '</script>');
+            . "').parentNode);" . '</script>');
     }
 }

app/code/core/Mage/Adminhtml/Block/Catalog/Category/Helper/Sortby/Available.php

@@ -55,6 +55,6 @@ public function getElementHtml()
             . Mage::helper('adminhtml')->__('Use All Available Attributes') . '</label>';
 
         return $html . ('<script type="text/javascript">toggleValueElements($(\'' . $htmlId . '\'), $(\'' . $htmlId
-            . '\').parentNode);</script>');
+            . "').parentNode);</script>");
     }
 }

app/code/core/Mage/Adminhtml/Block/Catalog/Category/Helper/Sortby/Default.php

@@ -56,6 +56,6 @@ public function getElementHtml()
             . Mage::helper('adminhtml')->__('Use Config Settings') . '</label>';
 
         return $html . ('<script type="text/javascript">toggleValueElements($(\'' . $htmlId . '\'), $(\'' . $htmlId
-            . '\').parentNode);</script>');
+            . "').parentNode);</script>");
     }
 }

app/code/core/Mage/Adminhtml/Block/Catalog/Helper/Form/Wysiwyg.php

@@ -30,7 +30,7 @@ public function getAfterElementHtml()
                     'type'    => 'button',
                     'disabled' => $disabled,
                     'class' => 'btn-wysiwyg',
-                    'onclick' => 'catalogWysiwygEditor.open(\'' . Mage::helper('adminhtml')->getUrl('*/*/wysiwyg') . '\', \'' . $this->getHtmlId() . '\')',
+                    'onclick' => "catalogWysiwygEditor.open('" . Mage::helper('adminhtml')->getUrl('*/*/wysiwyg') . "', '" . $this->getHtmlId() . "')",
                 ])->toHtml();
         }
 

app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Set/Toolbar/Add.php

@@ -27,7 +27,7 @@ protected function _prepareLayout()
             $this->getLayout()->createBlock('adminhtml/widget_button')
                 ->setData([
                     'label'     => Mage::helper('catalog')->__('Save Attribute Set'),
-                    'onclick'   => 'if (addSet.submit()) disableElements(\'save\');',
+                    'onclick'   => "if (addSet.submit()) disableElements('save');",
                     'class' => 'save',
                 ]),
         );

app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Action/Attribute/Tab/Attributes.php

@@ -86,7 +86,7 @@ protected function _getAdditionalElementHtml($element)
              . '-checkbox" ' . $nameAttributeHtml . ' onclick="toogleFieldEditMode(this, \'' . $element->getId()
              . '\')" /><label for="' . $element->getId() . '-checkbox">' . Mage::helper('catalog')->__('Change')
              . '</label></span>
-                <script type="text/javascript">initDisableFields(\'' . $element->getId() . '\')</script>';
+                <script type="text/javascript">initDisableFields(\'' . $element->getId() . "')</script>";
     }
 
     /**

app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Simple.php

@@ -108,7 +108,7 @@ protected function _prepareForm()
                 'values' => $attribute->getSource()->getAllOptions(true, true),
                 'required' => true,
                 'class'    => 'validate-configurable',
-                'onchange' => 'superProduct.showPricing(this, \'' . $attributeCode . '\')',
+                'onchange' => "superProduct.showPricing(this, '" . $attributeCode . "')",
             ]);
 
             $fieldset->addField('simple_product_' . $attributeCode . '_pricing_value', 'hidden', [