-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header logo skewing in Safari when scrolling down on page #111
Comments
Hey @xpurichan, Thanks for finding this one out. I have tested on Chrome, FF, Safari (macOS + iOS) Extra: There is some issue with the padding/margin on the hero banner making it extra narrow on small devices. The words (even short ones) are clipping. It is only visible on staging but there is quite a potential to break the prod site if the wording changes. |
Good catch @geoffguillain, I've copied their production banner on to the [staging site], edited the blocks and block settings, and pitched this and the logo update to them. Awaiting the partner's approval now. I'll ping you on the logo update once approved. |
@geoffguillain the partner would like to wait to apply this fix until the beginning of Sept. At that time I'll confirm a good day and time to push the update, and let you know in advance. |
Thanks for letting me know @xpurichan |
@xpurichan I'll be taking this over. Let me know when this is approved for production. Thank you |
Thanks @nate-allen , the partner has stopped responding to this request so I'll favor closing this issue for now. I'll reopen and ping you if this becomes active again. |
Description
While testing an unrelated issue, we noticed that the header logo becomes squished when we scroll down on the website's pages (initial load is fine). This behavior does not occur in Chrome or Chrome in our tests, but is present in Safari (both mobile and desktop) and possibly other browsers too.
Mobile:
![IMG_1863](https://private-user-images.githubusercontent.com/33190975/359172805-778692b3-5786-40ea-92f0-3a57083ec79c.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5OTUwODEsIm5iZiI6MTczODk5NDc4MSwicGF0aCI6Ii8zMzE5MDk3NS8zNTkxNzI4MDUtNzc4NjkyYjMtNTc4Ni00MGVhLTkyZjAtM2E1NzA4M2VjNzljLlBORz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDA2MDYyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY0NjU5NWUyYzZmMDVjZTFiMGRkODA4NWExNzYwMTljMTc0NzNkNDQ1ODFiOTcwMWUwNDU2Y2RlNzFmZThhYTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0._Vm7Li8pUbayxKsJ1Dd0YxQ6lHcSU6bRwyWsAVpt_pY)
Desktop:
![Screenshot 2024-08-19 at 11 19 16 AM](https://private-user-images.githubusercontent.com/33190975/359172850-32cdc47e-0f2d-4637-aa9d-c6f455e27965.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5OTUwODEsIm5iZiI6MTczODk5NDc4MSwicGF0aCI6Ii8zMzE5MDk3NS8zNTkxNzI4NTAtMzJjZGM0N2UtMGYyZC00NjM3LWFhOWQtYzZmNDU1ZTI3OTY1LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDA2MDYyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZiOWM5YzAxM2E0NWIxNzExOThhMGZjNjc5MjRkZmZhNjE4YjBkMmQ0MTIzMTgyM2QwMDM0OTcwM2M3NmZjYTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.-gVDRgvVtsI0InLa4ZJg2CJRJgMqzc0I8VRW54jUpio)
Possibly related to #104 cc @geoffguillain and @toncijajic
The text was updated successfully, but these errors were encountered: