Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header logo skewing in Safari when scrolling down on page #111

Closed
xpurichan opened this issue Aug 19, 2024 · 6 comments
Closed

Header logo skewing in Safari when scrolling down on page #111

xpurichan opened this issue Aug 19, 2024 · 6 comments

Comments

@xpurichan
Copy link

xpurichan commented Aug 19, 2024

Description

While testing an unrelated issue, we noticed that the header logo becomes squished when we scroll down on the website's pages (initial load is fine). This behavior does not occur in Chrome or Chrome in our tests, but is present in Safari (both mobile and desktop) and possibly other browsers too.

Mobile:
IMG_1863

Desktop:
Screenshot 2024-08-19 at 11 19 16 AM

Possibly related to #104 cc @geoffguillain and @toncijajic

@geoffguillain
Copy link
Collaborator

geoffguillain commented Aug 20, 2024

Hey @xpurichan,

Thanks for finding this one out.
Safari seems to behave differently. I have updated the CSS to fix this issue.

I have tested on Chrome, FF, Safari (macOS + iOS)
demo: https://open-source-initiative-development.mystagingwebsite.com/

Extra:

There is some issue with the padding/margin on the hero banner making it extra narrow on small devices. The words (even short ones) are clipping. It is only visible on staging but there is quite a potential to break the prod site if the wording changes.

image

@xpurichan
Copy link
Author

xpurichan commented Aug 21, 2024

Good catch @geoffguillain, I've copied their production banner on to the [staging site], edited the blocks and block settings, and pitched this and the logo update to them.

Awaiting the partner's approval now. I'll ping you on the logo update once approved.

@xpurichan
Copy link
Author

@geoffguillain the partner would like to wait to apply this fix until the beginning of Sept. At that time I'll confirm a good day and time to push the update, and let you know in advance.

@geoffguillain
Copy link
Collaborator

Thanks for letting me know @xpurichan
Waiting for approval to merge on prod!

@nate-allen
Copy link

@xpurichan I'll be taking this over. Let me know when this is approved for production. Thank you

@xpurichan
Copy link
Author

Thanks @nate-allen , the partner has stopped responding to this request so I'll favor closing this issue for now. I'll reopen and ping you if this becomes active again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants